.devcontainer/devcontainer.json

@@ -1,34 +1,26 @@
-// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
-// https://github.com/microsoft/vscode-dev-containers/tree/v0.245.2/containers/typescript-node
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+// README at: https://github.com/devcontainers/templates/tree/main/src/typescript-node
 {
-	"name": "Node.js & TypeScript",
-	"build": {
-		"dockerfile": "Dockerfile",
-		// Update 'VARIANT' to pick a Node version: 18, 16, 14.
-		// Append -bullseye or -buster to pin to an OS version.
-		// Use -bullseye variants on local on arm64/Apple Silicon.
-		"args": { 
-			"VARIANT": "18"
-		}
-	},
+  "name": "Node.js & TypeScript",
+  // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
+  "image": "mcr.microsoft.com/devcontainers/typescript-node:1-20-bullseye",
 
-	// Configure tool-specific properties.
-	"customizations": {
-		// Configure properties specific to VS Code.
-		"vscode": {
-			// Add the IDs of extensions you want installed when the container is created.
-			"extensions": [
-				"dbaeumer.vscode-eslint"
-			]
-		}
-	},
+  // Features to add to the dev container. More info: https://containers.dev/features.
+  // "features": {},
 
-	// Use 'forwardPorts' to make a list of ports inside the container available locally.
-	// "forwardPorts": [],
+  // Use 'forwardPorts' to make a list of ports inside the container available locally.
+  // "forwardPorts": [],
 
-	// Use 'postCreateCommand' to run commands after the container is created.
-	"postCreateCommand": "npm install",
+  // Use 'postCreateCommand' to run commands after the container is created.
+  "postCreateCommand": "npm install",
 
-	// Comment out to connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
-	"remoteUser": "node"
+  // Configure tool-specific properties.
+  "customizations": {
+    "vscode": {
+      "extensions": ["dbaeumer.vscode-eslint"]
+    }
+  }
+
+  // Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
+  // "remoteUser": "root"
 }

.eslintignore

@@ -10,6 +10,7 @@
 /lib
 !/.github
 !/.vscode
+!/.devcontainer
 !/docs/.vuepress
 !/docs/.vitepress
 /docs/.vuepress/dist

.eslintrc.js

@@ -73,6 +73,10 @@ module.exports = {
             selector: "method",
             format: null,
           },
+          {
+            selector: "import",
+            format: ["camelCase", "PascalCase", "UPPER_CASE"],
+          },
         ],
         "@typescript-eslint/no-non-null-assertion": "off",
       },

.github/workflows/GHPages.yml

@@ -25,21 +25,19 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - uses: actions/setup-node@v3
-        with:
-          node-version: 18
+      - uses: actions/setup-node@v4
       - name: Install Packages
-        run: npm install
+        run: npm install -f
       - name: Build docs
         run: npm run docs:build
       - name: Update docs
         run: npm run update
       - name: Setup Pages
-        uses: actions/configure-pages@v3
+        uses: actions/configure-pages@v4
       - name: Upload artifact
         uses: actions/upload-pages-artifact@v2
         with:
           path: ./docs/.vitepress/dist/eslint-plugin-yml
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v2
+        uses: actions/deploy-pages@v3

.github/workflows/NodeCI.yml

@@ -11,11 +11,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-node@v3
-        with:
-          node-version: 16
+      - uses: actions/setup-node@v4
       - name: Install Packages
-        run: npm install
+        run: npm install -f
       - name: Lint
         run: npm run lint
       - name: Build
@@ -24,24 +22,22 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14.x, 16.x, 17.x]
+        node-version: [14.x, 16.x, 18.x, 20.x]
     steps:
       - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
       - name: Install Packages
-        run: npm install
+        run: npm install -f
       - name: Test
         run: npm test
   test-with-eslint6:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-node@v3
-        with:
-          node-version: 16
+      - uses: actions/setup-node@v4
       - name: Install Target Packages
         run: |+
           npm i -D eslint@6 --legacy-peer-deps
@@ -51,15 +47,10 @@ jobs:
         run: npm test
   test-with-eslint7:
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        node-version: [16]
     steps:
       - uses: actions/checkout@v4
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
-        with:
-          node-version: ${{ matrix.node-version }}
+      - name: Use Node.js
+        uses: actions/setup-node@v4
       - name: Install Target Packages
         run: |+
           npm i -D eslint@7 --legacy-peer-deps
@@ -71,9 +62,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
       - name: Install Packages
-        run: npm install
+        run: npm install -f
       - name: Test
         run: |
           npm run cover

.github/workflows/Release.yml

@@ -15,15 +15,10 @@ jobs:
         with:
           # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
           fetch-depth: 0
-
       - name: Setup Node.js 16
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
+        uses: actions/setup-node@v4
       - name: Install Dependencies
-        run: npm install
-
+        run: npm install -f
       - name: Create Release Pull Request or Publish to npm
         id: changesets
         uses: changesets/action@v1

.github/workflows/format.yml

@@ -0,0 +1,31 @@
+name: 👔 Format
+
+on:
+  workflow_dispatch: null
+
+jobs:
+  format:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v4
+      - name: Setup node
+        uses: actions/setup-node@v4
+      - name: Install deps
+        run: npm install -f
+      - name: Format
+        run: npm run eslint-fix
+      - name: Commit
+        run: |
+          git config --local user.email "github-actions[bot]@users.noreply.github.com"
+          git config --local user.name "github-actions[bot]"
+
+          git add .
+          if [ -z "$(git status --porcelain)" ]; then
+            echo "no formatting changed"
+            exit 0
+          fi
+          git commit -m "chore: format"
+          git push
+          echo "pushed formatting changes https://github.com/$GITHUB_REPOSITORY/commit/$(git rev-parse HEAD)"

.github/workflows/stale.yml

@@ -13,7 +13,7 @@ jobs:
     name: Close stale issues with missing information
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@v8
+      - uses: actions/stale@v9
         with:
           any-of-labels: "needs repro,needs info,needs more info"
           days-before-stale: 60

.vscode/settings.json

@@ -17,8 +17,8 @@
   "css.validate": false,
   "typescript.tsdk": "node_modules/typescript/lib",
   "editor.codeActionsOnSave": {
-    "source.fixAll.eslint": true,
-    "source.fixAll.stylelint": true
+    "source.fixAll.eslint": "explicit",
+    "source.fixAll.stylelint": "explicit"
   },
   "stylelint.validate": [
     "css",

CHANGELOG.md

@@ -1,5 +1,11 @@
 # eslint-plugin-yml
 
+## 1.11.0
+
+### Minor Changes
+
+- [#288](https://github.com/ota-meshi/eslint-plugin-yml/pull/288) [`d852113`](https://github.com/ota-meshi/eslint-plugin-yml/commit/d8521132623858ebfbef6bee79cda8c6333948db) Thanks [@ota-meshi](https://github.com/ota-meshi)! - Improve compatibility with ESLint v9
+
 ## 1.10.0
 
 ### Minor Changes

docs/.vitepress/config.mts

@@ -1,6 +1,5 @@
 import type { DefaultTheme, UserConfig } from "vitepress";
 import { defineConfig } from "vitepress";
-import { BUNDLED_LANGUAGES } from "shiki";
 import path from "path";
 import { fileURLToPath } from "url";
 import eslint4b from "vite-plugin-eslint4b";
@@ -10,10 +9,6 @@ import { viteCommonjs } from "./vite-plugin.mjs";
 import "./build-system/build.js";
 const dirname = path.dirname(fileURLToPath(import.meta.url));
 
-// Include `json5` as alias for jsonc
-const jsonc = BUNDLED_LANGUAGES.find((lang) => lang.id === "jsonc");
-if (jsonc) jsonc.aliases = [...(jsonc?.aliases ?? []), "json5"];
-
 function ruleToSidebarItem({
   meta: {
     docs: { ruleId, ruleName },

docs/.vitepress/theme/components/playground-block.vue

@@ -83,21 +83,31 @@ export default {
     serializedString(serializedString) {
       if (
         typeof window !== "undefined" &&
-        serializedString !== window.location.hash.slice(1)
+        serializedString !== window.location.hash.slice(1) &&
+        !this._initializing
       ) {
         window.location.replace(`#${serializedString}`);
       }
     },
   },
   mounted() {
-    this.onUrlHashChange();
     if (typeof window !== "undefined") {
-      window.addEventListener("hashchange", this.onUrlHashChange);
+      window.addEventListener("hashchange", this.processUrlHashChange);
+    }
+    const serializedString =
+      (typeof window !== "undefined" && window.location.hash.slice(1)) || "";
+    if (serializedString) {
+      this._initializing = true;
+      this.rules = {};
+      this.$nextTick().then(() => {
+        this._initializing = false;
+        this.processUrlHashChange();
+      });
     }
   },
-  beforeDestroey() {
+  beforeUnmount() {
     if (typeof window !== "undefined") {
-      window.removeEventListener("hashchange", this.onUrlHashChange);
+      window.removeEventListener("hashchange", this.processUrlHashChange);
     }
   },
   methods: {
@@ -107,14 +117,16 @@ export default {
     getRule(ruleId) {
       return getRule(ruleId);
     },
-    onUrlHashChange() {
+    processUrlHashChange() {
       const serializedString =
         (typeof window !== "undefined" && window.location.hash.slice(1)) || "";
       if (serializedString !== this.serializedString) {
         const state = deserializeState(serializedString);
         this.code = state.code || DEFAULT_CODE;
         this.rules = state.rules || Object.assign({}, DEFAULT_RULES_CONFIG);
+        return true;
       }
+      return false;
     },
   },
 };

docs/.vitepress/theme/components/rules/index.js

@@ -76,12 +76,12 @@ categories.sort((a, b) =>
   a.categoryOrder > b.categoryOrder
     ? 1
     : a.categoryOrder < b.categoryOrder
-    ? -1
-    : a.title > b.title
-    ? 1
-    : a.title < b.title
-    ? -1
-    : 0,
+      ? -1
+      : a.title > b.title
+        ? 1
+        : a.title < b.title
+          ? -1
+          : 0,
 );
 
 export const DEFAULT_RULES_CONFIG = allRules.reduce((c, r) => {