Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml import in ESM #187

Merged
merged 4 commits into from
May 24, 2024
Merged

Conversation

alecmev
Copy link
Contributor

@alecmev alecmev commented May 17, 2024

Fix #175

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: 449436c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
yaml-eslint-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alecmev
Copy link
Contributor Author

alecmev commented May 17, 2024

@ota-meshi Feel free to adjust the naming of anything or the way it's tested, of course 😉

@ota-meshi
Copy link
Owner

Oh... first I need to fix the already broken lint error.

Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the pull request.

@ota-meshi ota-meshi merged commit 4dc647e into ota-meshi:master May 24, 2024
6 checks passed
@alecmev
Copy link
Contributor Author

alecmev commented Jun 7, 2024

Thanks!

@alecmev alecmev deleted the strict-type-check branch June 7, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't depend on yaml/dist/doc/directives, or get yaml to export Directives
2 participants