Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline-block may cause Chrome's built-in search to fail to match the corresponding content #101

Open
colorpeach opened this issue Jul 28, 2020 · 5 comments
Labels

Comments

@colorpeach
Copy link
Contributor

colorpeach commented Jul 28, 2020

display: inline-block;

Assuming that the rendered code is like this

<td class="diff-code diff-code-insert" style="user-select: auto;">
    <span class="diff-code-edit">
        <span class="token function">onU</span>
    </span>
    <span class="token function">pdat</span>
    <span class="diff-code-edit">
        <span class="token function">e</span>
    </span>
</td>

When I use ctrl+f to search for "onUpdate" on the webpage, I cannot find the above one because the display of .diff-code-edit is inline-block.

I think display: inline-block should be changed to display: inline.

@otakustay
Copy link
Owner

Aware of this issue, but currently I can't find an appropriate solution, inline-flex also breaks search

@otakustay
Copy link
Owner

But why we are using inline-block, just can't remember, any idea @dancerphil ?

@stale
Copy link

stale bot commented Aug 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 11, 2020
@stale stale bot removed the stale label Aug 11, 2020
@ensorrow
Copy link

already fixed in #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants