Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction page: navigating to Trace tab and back is broken #1560

Closed
2 tasks done
sealer3 opened this issue Dec 2, 2023 · 0 comments · Fixed by #1561
Closed
2 tasks done

Transaction page: navigating to Trace tab and back is broken #1560

sealer3 opened this issue Dec 2, 2023 · 0 comments · Fixed by #1561
Assignees
Labels
bug Something isn't working

Comments

@sealer3
Copy link
Collaborator

sealer3 commented Dec 2, 2023

The tabs somehow are trying to navigate relative to the current URL and not the transaction URL, so if you click the Trace tab enough times, you get

/tx/0xaf226ef77eae07429d123f3779ec747580dcf1b621014acf9085fcb426a783b0/trace/trace/trace/trace/trace/trace/trace/trace/trace/trace

The cause seems to be from this update to react-router-dom: c96c36a

The reason was that we relied on so-called "buggy behavior" of the router, and so we need to update to react-router-dom v6.20.1 and/or figure out the correct way of referencing things relative to the parent page, not the current page: remix-run/react-router#11052 (comment)

  • Fix navigation Update to v6.20.1
  • Add end-to-end test

According to the React Router issue I linked to above, the authors of React Router will release a statement with explanations about how to migrate to the new behavior.

@sealer3 sealer3 added the bug Something isn't working label Dec 2, 2023
@sealer3 sealer3 self-assigned this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant