Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Log replacements without requiring verbose if not silent #103

Open
Unicycle77 opened this issue Aug 26, 2022 · 0 comments

Comments

@Unicycle77
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch grunt-replace@2.0.2 for the project I'm working on.

When upgrading from grunt-replace 0.4.0 to 2.0.2, we lost the logging of each replacement. With a large batch of replacements, it's very helpful to see these log entries, since they are the only indication of progress. Turning verbose mode on is not an option, because it applies to other modules. (in our case logging roughly 10 lines per file)

Here is the diff that solved my problem:

diff --git a/node_modules/grunt-replace/tasks/replace.js b/node_modules/grunt-replace/tasks/replace.js
index c0428b4..153fd7f 100644
--- a/node_modules/grunt-replace/tasks/replace.js
+++ b/node_modules/grunt-replace/tasks/replace.js
@@ -52,8 +52,8 @@ module.exports = function (grunt) {
           result = content;
         }
 
-        if (result !== false) {
-          grunt.verbose.writeln('Replace ' + chalk.cyan(source) + ' → ' +
+        if (result !== false && options.silent !== true) {
+          grunt.log.writeln('Replace ' + chalk.cyan(source) + ' → ' +
             chalk.green(target));
         }
 

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant