External scope vars used in computed method key not captured where var with same name used inside method

[overlookmotel]

Input:

const x = 'q';
export default () => ( {
  [x](x) {
    return x;
  }
} );

Serialized output:

export default () => ({
  [x](x) {
    return x;
  }
});

The external scope var x with value 'q' has not been captured, so this serialized output will throw an error when run.

This is at least partly due to bug in Babel babel/babel#12790 but may also require a fix in Livepack's Babel plugin to correctly track what function the visitor is currently in while processing computed method keys.

[overlookmotel]

Babel bug babel/babel#12790 now fixed and fix is in latest Babel releases.

[overlookmotel]

Uncomment these tests once this is fixed:

livepack/test/eval.test.js

Line 368 in 3f687fe

describe('defined in method key', () => {

[overlookmotel]

This is at least partially solved after the bug fix in Babel. The example above does now serialize correctly.

However, does not work for this, arguments or super in computed method key.

[overlookmotel]

This may have been fixed by ebf9322. Need to check.

[overlookmotel]

These inputs are now serialized as expected:

const x = 'q';
let fn;
({
  [ fn = (0, () => x) ](x) {}
});
export default fn;

let fn;
(function() {
  ({
    [ fn = (0, () => [this, arguments]) ]() {}
  });
}).call( 1, 2, 3, 4 );
export default fn;

export default function() {
  return () => ({
    [ () => [this, arguments] ]() {}
  });
}.call(1, 2, 3, 4);

let fn;
class X {
  constructor() {
    ({
      [ fn = (0, () => super.toString) ]() {}
    });
  }
}
new X();
export default fn;

let fn;
({
  foo() {
    ({
      [ fn = (0, () => super.toString) ]() {}
    });
  }
}).foo();
export default fn;

Appears to be fixed. Leaving issue open as still need to write tests.