Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Password manager in vSphere MFA signin form #9404

Open
1 task done
jlecour opened this issue Jun 6, 2023 · 2 comments
Open
1 task done

Support Password manager in vSphere MFA signin form #9404

jlecour opened this issue Jun 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jlecour
Copy link

jlecour commented Jun 6, 2023

Have you already contact our help centre?

  • Yes, I have contact the help centre.

Describe the problem

The vSphere MFA login form prevents password managers (like 1Password) to auto-fill the one-time password (TOTP).

Here is the current form HTML code :

<form class="form-2fa" method="POST">
      <input type="text" id="login" name="u" placeholder="Login"><br>
      <input type="text" id="token" name="p" class="pincode" placeholder="Authentication Token" maxlength="7"><br>
      <button type="submit">Confirm</button>
    </form>

The autocomplete from the password manager adds only 3 of the 6 digits or the TOTP.

Describe the solution

If I add some autocomplete attributes (like documented here and there) it works :

<form class="form-2fa" method="POST">
      <input type="text" id="login" name="u" autocomplete="username" placeholder="Login"><br>
      <input type="text" id="token" name="p" autocomplete="one-time-code" class="pincode" placeholder="Authentication Token" maxlength="7"><br>
      <button type="submit">Confirm</button>
    </form>

Describe alternatives you've considered

No response

Additional context

No response

@jlecour jlecour added the enhancement New feature or request label Jun 6, 2023
@jlecour
Copy link
Author

jlecour commented Jun 13, 2023

As a temporary workaround, I've added the Code Injector extension to Firefox with this rule :

Path: https://pcc-[-0-9]+\.ovh\.com/auth/auth

Javascript:

document.getElementById("login").setAttribute("autocomplete", "username")
document.getElementById("token").setAttribute("autocomplete", "one-time-code")

It works great, validating the real fix on your side.

@jlecour
Copy link
Author

jlecour commented Mar 19, 2024

This still hits me everyday on browsers where I can't have my workaround.

Is there any reason for not fixing this in the form ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant