Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6] Feature: disable use of remote audit by default #242

Open
prabhu opened this issue Feb 11, 2024 · 2 comments
Open

[v6] Feature: disable use of remote audit by default #242

prabhu opened this issue Feb 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@prabhu
Copy link
Member

prabhu commented Feb 11, 2024

Request Description

For npm, the remote audit is enabled by default to avoid false negatives. Let's make this in an opt-in in v6 to prefer offline-only first.

Additional Information

How do we deal with the fact that we might miss legitimate malware since the vdb is rebuilt only every x hours or so, and users might forget to refresh the database periodically?

@prabhu prabhu added the enhancement New feature or request label Feb 11, 2024
@cerrussell
Copy link
Collaborator

cerrussell commented Feb 14, 2024

@prabhu I had started on a config file for depscan that would include allowing the user to set a setting to periodically update vdb at a user-specified interval. My thought was that we could also store the date/time of the last update and log that info at the beginning of every scan so that the user would be aware.

How about I return to this and add to v6... there are other things I want to incorporate into it when I have time, but this part is quite easy.

@prabhu
Copy link
Member Author

prabhu commented Feb 14, 2024

Thanks @cerrussell. Adding this to the config file is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants