Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todos #207

Open
2 of 4 tasks
kinxiel opened this issue Sep 13, 2023 · 4 comments
Open
2 of 4 tasks

Todos #207

kinxiel opened this issue Sep 13, 2023 · 4 comments

Comments

@kinxiel
Copy link
Collaborator

kinxiel commented Sep 13, 2023

Just listing some todos before separating them into their own issues.

  • Fix Static Site Rendering Issues: sometimes old site is shown momentarily.
  • Improve Join page on mobile.
  • Clean up CSS.
  • Fix event countdown. If it's less then a day: hours. If it's less then a week: days. If it's less than a month: half weeks rounded down with "about" prefixed unless it's to the day exactly x weeks. Else same strategy but for months.
@nakajimayoshi
Copy link

Hey there, noticed these TODOs and other issues have been open for awhile, still need any help on them? I can get started this weekend.

@kinxiel
Copy link
Collaborator Author

kinxiel commented Feb 10, 2024

That would be super. Updated the list.

@nakajimayoshi
Copy link

nakajimayoshi commented Feb 12, 2024

@kinxiel

For item #3, what would a "cleaned" up version of the css look like? "Clean" is very subjective, as I've seen much, much worse CSS files than this.

There's a few ways to tackle this:

  1. Divide classes with separate responsibilities into separate css files.

  2. Use SCSS to inherit widely used css and use helper functions

  3. Keep it all in one file, but reduce the amount of classes used/get rid of unused classes.

@martinheidegger
Copy link
Member

@nakajimayoshi you pointed out a few of the aims correctly. There are a few priorities as I see them.

  1. Have the same system everywhere (not different naming structures)
  2. Detach from vue so we can switch out vue at some point with react
  3. Reduce redundancies: Make sure that everywhere the same properties are used.

It should probably be better done in stages as doing everything in one sweep may be hard to review and make sure that things still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants