Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Accordion improvements #914

Open
1 of 7 tasks
kulmann opened this issue Oct 28, 2020 · 1 comment
Open
1 of 7 tasks

Accordion improvements #914

kulmann opened this issue Oct 28, 2020 · 1 comment
Labels
accessibility enhancement New feature or request

Comments

@kulmann
Copy link
Member

kulmann commented Oct 28, 2020 •
edited by JammingBen

We recently re-implemented the accordion component. It still needs some adjustments/improvements, but we didn't want to block the initial release.

Things left to do:

  • vertical alignment of title is off (height is different than icons, vertical alignment fails)
  • accessibility: visible focus
  • accessibility: down-arrow and up-arrow keystrokes should move between accordion item headers
  • animation on accordion body expanding/collapsing
  • add unit tests
  • add a11y tests
  • add separators for accordion items (no <hr />, but more of a proper component outline)
@kulmann kulmann added accessibility enhancement New feature or request labels Oct 28, 2020
@kulmann kulmann mentioned this issue Oct 28, 2020
Merged
2 tasks
@JammingBen
Copy link
Contributor

accessibility: visible focus

Fixed with #1158

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accessibility enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kulmann @JammingBen