Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Dav properties for shared files #311

Open
LukasHirt opened this issue Aug 7, 2019 · 12 comments
Open

Dav properties for shared files #311

LukasHirt opened this issue Aug 7, 2019 · 12 comments
Assignees

Comments

@LukasHirt
Copy link
Contributor

Description

When listing files shared with others we need to access dav properties [e. g. permissions (getting only permissions from the share for the receiver), etag...]. I guess we need to create a proper api method.

@DeepDiver1975
Copy link
Member

according to https://doc.owncloud.com/server/developer_manual/core/apis/ocs-share-api.html#example-request-response-payloads-2 a share holds the file id of the shared file/folder in the property file_source

using oc.files.fileInfo all file properties can be queried.

do I miss anything?

@LukasHirt
Copy link
Contributor Author

Then we need to do api call for every file we get from the share api. Would then eat quite a lot of performance, wouldn't it?

@DeepDiver1975
Copy link
Member

very much true ..... let me think about this ....

@DeepDiver1975
Copy link
Member

Then we only show the information we have .... just like in oc10
Screenshot from 2019-08-08 16-34-50

@LukasHirt
Copy link
Contributor Author

LukasHirt commented Aug 8, 2019

Well we still need to get the permissions otherwise we need to drop actions. Same for etag and versions. (both are in old UI)

@DeepDiver1975
Copy link
Member

Before loading the sidebar we can load all necessary additional information using oc.files.fileinfo

Regarding the permissions .....

  • for incoming you can use the share permissions (bitmask)
  • for outgoing you can assume that the user has full access

does that make sense?

@LukasHirt
Copy link
Contributor Author

Before loading the sidebar we can load all necessary additional information using oc.files.fileinfo

Ah, right

  • for outgoing you can assume that the user has full access

Well the user can be only viewer but still be able to share.

@DeepDiver1975
Copy link
Member

Well the user can be only viewer but still be able to share.

let me test this in oc10 ....

@DeepDiver1975
Copy link
Member

I just tried:

  • A shares folder with B read+share
  • B re-shares it with C with what ever permissions
  • The folder will not be listed for B as outgoing but for A - who has full access

🤷‍♂️

@LukasHirt
Copy link
Contributor Author

Tried the same.

  • Shared file as Admin with Bob as Viewer with can share permission
  • Shared the same file as Bob with Alice
  • File is in the shared with others list for Bob

image

@LukasHirt
Copy link
Contributor Author

What about dropping actions in that list for now and let's solve it later so we can deliver the milestone?

@PVince81
Copy link

actions will reappear as part of the resolution of owncloud/web#2077

@DeepDiver1975 DeepDiver1975 removed their assignment Sep 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants