Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Discuss: throw error when settings service is unavailable? #476

Open
kulmann opened this issue May 22, 2020 · 2 comments
Open

Discuss: throw error when settings service is unavailable? #476

kulmann opened this issue May 22, 2020 · 2 comments

Comments

@kulmann
Copy link
Member

kulmann commented May 22, 2020

There are two situations in which the settings service could not be available. At the moment, sdk is returning an empty array in both situations.

1: Settings service is not set up / configured at all. -> valid to fall back to defaults
2: Settings service is temporarily not available. -> should throw an error instead of returning defaults. Would be confusing for the user to fall back to defaults.

We need to discuss this. It's probably a good idea to fail on temporarily not available settings service.

@wkloucek
Copy link
Contributor

Can we go forward once we have a capability for the settings service? (owncloud/ocis#2655)

@pascalwengerter
Copy link
Contributor

Can we go forward once we have a capability for the settings service? (owncloud/ocis#2655)

I'd hope so, good point!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants