Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sharing NG] Make proper use of share permissions instead of roles #10770

Open
JammingBen opened this issue Apr 12, 2024 · 0 comments
Open

[Sharing NG] Make proper use of share permissions instead of roles #10770

JammingBen opened this issue Apr 12, 2024 · 0 comments
Labels

Comments

@JammingBen
Copy link
Collaborator

JammingBen commented Apr 12, 2024

With Sharing NG, roles and permissions are coming from the server. While there is a predefined set of available permissions, roles are simply a "bucket" of permissions. In the future we even may have custom roles per instance, which makes it impossible to rely on roles.

Therefore Web should switch its focus on permissions and only use/display role information if the server returns a matching role for a given set of permissions.

Acceptance criteria

  • Make sure all available permissions are included in GraphSharePermission (https://github.com/owncloud/web/blob/master/packages/web-client/src/helpers/share/types.ts#L4). Check against ocis to verify this.
  • Rename GraphSharePermission to DriveItemPermission
  • Remove all role checks (e.g. share.role.id !== GraphShareRoleIdMap.SpaceManager) in favour of permission checks
  • Remove GraphShareRoleIdMap(?) We might implement something similar for tests though? Now sure...
  • Re-think the hard-coded keys of the spaceRoles property in the SpaceResource interface. These names can break when the server adds new roles or renames existing.
  • Make sure that permissions are being displayed in case a set of permissions doesn't have a matching role coming from the server.
    • How do we display the permissions without cluttering the UI? We probably shouldn't list all permissions coming from the server. @tbsbdr
@JammingBen JammingBen added Category:Change Change existing functionality Status:Needs-Info labels Apr 12, 2024
@JammingBen JammingBen mentioned this issue Apr 12, 2024
41 tasks
@JammingBen JammingBen added Category:Technical Technical ehancements and removed Category:Change Change existing functionality labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant