Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 10814: Make OcModal vertically scrollable #10816

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix 10814: Make OcModal vertically scrollable #10816

merged 1 commit into from
May 15, 2024

Conversation

pascalwengerter
Copy link
Contributor

@update-docs Update Docs
Copy link

update-docs bot commented Apr 23, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

JammingBen
JammingBen requested changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modals now always show a scrollbar for me 😅

image

Also please don't forget to target this to stable-8.0.

@pascalwengerter
Copy link
Contributor Author

Modals now always show a scrollbar for me 😅
image

Also please don't forget to target this to stable-8.0.

I've changed the overflow-y from scroll to auto, which should prevent the issue you pointed out. Backport happens in #10819

JammingBen
JammingBen reviewed Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still having some issues, the scrollbar is now showing for smaller modals as well:

image

@pascalwengerter pascalwengerter force-pushed the bugfix/10814 branch 2 times, most recently from 9068909 to 003d5a4 Compare May 15, 2024 12:05
@pascalwengerter pascalwengerter changed the base branch from master to stable-8.0 May 15, 2024 12:20
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

kulmann
kulmann approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann requested a review from AlexAndBear May 15, 2024 12:38
@JammingBen JammingBen merged commit b8a192c into owncloud:stable-8.0 May 15, 2024
3 checks passed
@pascalwengerter pascalwengerter deleted the bugfix/10814 branch May 16, 2024 12:36
@JammingBen JammingBen mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen JammingBen approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link creation modal not scrollable
3 participants
@pascalwengerter @kulmann @JammingBen