Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oxc-resolver-has-issue-in-esbuild-test-case-packagejson-2002b #159

Closed
zhusjfaker opened this issue May 13, 2024 · 9 comments
Closed

oxc-resolver-has-issue-in-esbuild-test-case-packagejson-2002b #159

zhusjfaker opened this issue May 13, 2024 · 9 comments

Comments

@zhusjfaker
Copy link

zhusjfaker commented May 13, 2024

master

i'm dev rolldown for esbuild package_json test cases

when i migrate TestPackageJsonBrowserIssue2002B

https://github.com/evanw/esbuild/blob/main/internal/bundler_tests/bundler_packagejson_test.go#L830

i found some resovle error in oxc-resolver

please help me check

In order to quickly reproduce the bug I've created a git repo of code that can be reproduced.

https://github.com/zhusjfaker/oxc-resolver-has-issue-in-esbuild-test-case-packagejson-2002b/blob/master/tests/mod.rs#L44

https://github.com/zhusjfaker/oxc-resolver-has-issue-in-esbuild-test-case-packagejson-2002b

@zhusjfaker

This comment was marked as off-topic.

@Boshen
Copy link
Member

Boshen commented May 13, 2024

Interesting, we'll need to confirm with enhanced-resolve for this behaviour, since there is no formal spec for the browser field, and the official spec doesn't say anything about this https://github.com/defunctzombie/package-browser-field-spec. But esbuild's behaviour is also reasonable.

@zhusjfaker
Copy link
Author

Interesting, we'll need to confirm with enhanced-resolve for this behaviour, since there is no formal spec for the browser field, and the official spec doesn't say anything about this https://github.com/defunctzombie/package-browser-field-spec. But esbuild's behaviour is also reasonable.

thank you master

@zhusjfaker
Copy link
Author

If there are any updates to get a follow-up not under consideration for support, please update the latest status and I'll keep an eye out for replies Thank you master

@zhusjfaker

This comment was marked as off-topic.

@Boshen
Copy link
Member

Boshen commented May 13, 2024

Please don't @ if it's not urgent, I will go through github notifications accordingly.

@zhusjfaker

This comment was marked as off-topic.

@hyf0
Copy link
Contributor

hyf0 commented May 14, 2024

@Boshen
Copy link
Member

Boshen commented May 27, 2024

I'm going to close this as not planned, here are my reasonings:

  • The original feature request didn't come from an actual user land usage
  • the use case is super weird, there are no relevant teaching source that advocate this usage
  • browser field is outdated, has no spec, and is superseded by package exports
  • I've already spent like maybe 100 hours on the browser fields, it's a mine field and I don't want to spend more time on it. I don't want to spend on something that is outdated, has no spec. Every bug or feature involves at least two hours of reading the specification, doing tests, and find edge cases.

Please don't tell me to support it just because it's supported by another bundler, this is not a reason to support a feature.

I'll reconsider this if this use case comes up in user land.

Sorry for being harsh, I'm just really frustrated by browser fields.

@Boshen Boshen closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants