-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oxc-resolver-has-issue-in-esbuild-test-case-packagejson-2002b #159
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
Interesting, we'll need to confirm with enhanced-resolve for this behaviour, since there is no formal spec for the browser field, and the official spec doesn't say anything about this https://github.com/defunctzombie/package-browser-field-spec. But esbuild's behaviour is also reasonable. |
thank you master |
If there are any updates to get a follow-up not under consideration for support, please update the latest status and I'll keep an eye out for replies Thank you master |
This comment was marked as off-topic.
This comment was marked as off-topic.
Please don't @ if it's not urgent, I will go through github notifications accordingly. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Some contexts:
|
I'm going to close this as not planned, here are my reasonings:
Please don't tell me to support it just because it's supported by another bundler, this is not a reason to support a feature. I'll reconsider this if this use case comes up in user land. Sorry for being harsh, I'm just really frustrated by |
master
i'm dev rolldown for esbuild package_json test cases
when i migrate TestPackageJsonBrowserIssue2002B
https://github.com/evanw/esbuild/blob/main/internal/bundler_tests/bundler_packagejson_test.go#L830
i found some resovle error in oxc-resolver
please help me check
In order to quickly reproduce the bug I've created a git repo of code that can be reproduced.
https://github.com/zhusjfaker/oxc-resolver-has-issue-in-esbuild-test-case-packagejson-2002b/blob/master/tests/mod.rs#L44
https://github.com/zhusjfaker/oxc-resolver-has-issue-in-esbuild-test-case-packagejson-2002b
The text was updated successfully, but these errors were encountered: