/
namespace.rs
251 lines (234 loc) · 12.3 KB
/
namespace.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
use oxc_ast::{ast::BindingPatternKind, AstKind};
use oxc_diagnostics::{
miette::{self, Diagnostic},
thiserror::Error,
};
use oxc_macros::declare_oxc_lint;
use oxc_span::{CompactStr, GetSpan, Span};
use oxc_syntax::module_record::ImportImportName;
use crate::{context::LintContext, rule::Rule};
#[derive(Debug, Error, Diagnostic)]
enum NamespaceDiagnostic {
#[error("eslint-plugin-import(namespace): {1:?} not found in imported namespace {2:?}.")]
#[diagnostic(severity(warning))]
NoExport(#[label] Span, CompactStr, CompactStr),
#[error("eslint-plugin-import(namespace): Unable to validate computed reference to imported namespace {1:?}
.")]
#[diagnostic(severity(warning))]
ComputedReference(#[label] Span, CompactStr),
#[error("eslint-plugin-import(namespace): Assignment to member of namespace {1:?}.'")]
#[diagnostic(severity(warning))]
Assignment(#[label] Span, CompactStr),
}
/// <https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/namespace.md>
#[derive(Debug, Default, Clone)]
pub struct Namespace;
declare_oxc_lint!(
/// ### What it does
/// Enforces names exist at the time they are dereferenced, when imported as a full namespace (i.e. import * as foo from './foo'; foo.bar(); will report if bar is not exported by ./foo.).
/// Will report at the import declaration if there are no exported names found.
/// Also, will report for computed references (i.e. foo["bar"]()).
/// Reports on assignment to a member of an imported namespace.
Namespace,
nursery
);
impl Rule for Namespace {
fn run_once(&self, ctx: &LintContext<'_>) {
ctx.semantic().module_record().import_entries.iter().for_each(|entry| {
if !matches!(entry.import_name, ImportImportName::NamespaceObject) {
return;
}
let source = entry.module_request.name();
let module_record = ctx.semantic().module_record();
let Some(module) = module_record.loaded_modules.get(source) else {
return;
};
if module.not_esm {
return;
}
let Some(symbol_id) =
ctx.semantic().symbols().get_symbol_id_from_span(&entry.local_name.span())
else {
return;
};
let check_binding_exported = |name: &str, span| {
if module.exported_bindings.contains_key(name)
|| module
.exported_bindings_from_star_export
.iter()
.any(|entry| entry.value().contains(&CompactStr::from(name)))
{
return;
}
ctx.diagnostic(NamespaceDiagnostic::NoExport(span, name.into(), source.clone()));
};
ctx.symbols().get_resolved_references(symbol_id).for_each(|reference| {
if let Some(node) = ctx.nodes().parent_node(reference.node_id()) {
let name = entry.local_name.name();
match node.kind() {
AstKind::MemberExpression(member) => {
if matches!(
ctx.nodes().parent_kind(node.id()),
Some(AstKind::SimpleAssignmentTarget(_))
) {
ctx.diagnostic(NamespaceDiagnostic::Assignment(
member.span(),
name.clone(),
));
};
// TODO: Support allow_computed option
if member.is_computed() {
return ctx.diagnostic(NamespaceDiagnostic::ComputedReference(
member.span(),
name.clone(),
));
}
if let Some((span, name)) = member.static_property_info() {
check_binding_exported(name, span);
}
}
AstKind::JSXMemberExpressionObject(_) => {
if let Some(AstKind::JSXMemberExpression(expr)) =
ctx.nodes().parent_kind(node.id())
{
check_binding_exported(&expr.property.name, expr.property.span);
}
}
AstKind::VariableDeclarator(decl) => {
let BindingPatternKind::ObjectPattern(pattern) = &decl.id.kind else {
return;
};
pattern.properties.iter().for_each(|property| {
if let Some(name) = property.key.name() {
check_binding_exported(&name, property.key.span());
}
});
}
_ => {}
}
}
});
});
}
}
#[test]
fn test() {
use crate::tester::Tester;
let pass = vec![
r#"import "./malformed.js""#,
r"import * as foo from './empty-folder';",
r#"import * as names from "./named-exports"; console.log((names.b).c);"#,
r#"import * as names from "./named-exports"; console.log(names.a);"#,
r#"import * as names from "./re-export-names"; console.log(names.foo);"#,
r"import * as elements from './jsx';",
r#"import * as foo from "./jsx/re-export.js";
// console.log(foo.jsxFoo);"#,
r#"import * as foo from "./jsx/bar/index.js";
// console.log(foo.Baz1);
// console.log(foo.Baz2);
// console.log(foo.Qux1);
// console.log(foo.Qux2);"#,
r"import * as foo from './common';",
r#"import * as names from "./named-exports"; const { a } = names"#,
r#"import * as names from "./named-exports"; const { d: c } = names"#,
r#"import * as names from "./named-exports";
// const { c } = foo,
// { length } = "names",
// alt = names;"#,
r#"import * as names from "./named-exports"; const { ExportedClass: { length } } = names"#,
r#"import * as names from "./named-exports"; function b(names) { const { c } = names }"#,
r#"import * as names from "./named-exports"; function b() { let names = null; const { c } = names }"#,
r#"import * as names from "./named-exports"; const x = function names() { const { c } = names }"#,
r#"export * as names from "./named-exports""#,
// r#"export * as names from "./does-not-exist""#,
// r#"import * as Endpoints from "./issue-195/Endpoints"; console.log(Endpoints.Users)"#,
r#"function x() { console.log((names.b).c); } import * as names from "./named-exports";"#,
// r#"import * as names from './default-export';"#,
// r#"import * as names from './default-export'; console.log(names.default)"#,
// r#"export * as names from "./default-export""#,
// r#"export defport, * as names from "./default-export""#,
// r"import * as names from './named-exports'; console.log(names['a']);",
r"import * as names from './named-exports'; const {a, b, ...rest} = names;",
r"import * as ns from './re-export-common'; const {foo} = ns;",
r#"import * as Names from "./named-exports"; const Foo = <Names.a/>"#,
// r#"import * as foo from "./typescript-declare-nested"
// foo.bar.MyFunction()"#,
// r#"import { foobar } from "./typescript-declare-interface""#,
// r#"export * from "typescript/lib/typescript.d""#,
// r#"export = function name() {}"#,
// r#"for (let { foo, bar } of baz) {}"#,
// r#"for (let [ foo, bar ] of baz) {}"#,
// r#"const { x, y } = bar"#,
// r#"const { x, y, ...z } = bar"#,
// r#"let x; export { x }"#,
// r#"let x; export { x as y }"#,
// r#"export const x = null"#,
// r#"export var x = null"#,
// r#"export let x = null"#,
// r#"export default x"#,
// r#"export default class x {}"#,
// r#"import json from "./data.json""#,
// r#"import foo from "./foobar.json";"#,
// r#"import foo from "./foobar";"#,
// r#"import { foo } from "./issue-370-commonjs-namespace/bar""#,
// r#"export * from "./issue-370-commonjs-namespace/bar""#,
// r#"import * as a from "./commonjs-namespace/a"; a.b"#,
// r#"import { foo } from "./ignore.invalid.extension""#,
// r#"import * as color from './color';
// export const getBackgroundFromColor = (color) => color.bg;
// export const getExampleColor = () => color.example"#,
// r#"import * as middle from './middle';
// console.log(middle.myName);"#,
// r#"import * as names from './default-export-string';"#,
// r#"import * as names from './default-export-string'; console.log(names.default)"#,
// r#"import * as names from './default-export-namespace-string';"#,
// r#"import * as names from './default-export-namespace-string'; console.log(names.default)"#,
// r#"import { "b" as b } from "./deep/a"; console.log(b.c.d.e)"#,
// r#"import { "b" as b } from "./deep/a"; var {c:{d:{e}}} = b"#,
// r#"import * as a from "./deep/a"; console.log(a.b.c.d.e)"#,
// r#"import { b } from "./deep/a"; console.log(b.c.d.e)"#,
// r#"import * as a from "./deep/a"; console.log(a.b.c.d.e.f)"#,
// r#"import * as a from "./deep/a"; var {b:{c:{d:{e}}}} = a"#,
// r#"import { b } from "./deep/a"; var {c:{d:{e}}} = b"#,
// r#"import * as a from "./deep-es7/a"; console.log(a.b.c.d.e)"#,
// r#"import { b } from "./deep-es7/a"; console.log(b.c.d.e)"#,
// r#"import * as a from "./deep-es7/a"; console.log(a.b.c.d.e.f)"#,
// r#"import * as a from "./deep-es7/a"; var {b:{c:{d:{e}}}} = a"#,
// r#"import { b } from "./deep-es7/a"; var {c:{d:{e}}} = b"#,
];
let fail = vec![
r"import * as names from './named-exports'; console.log(names.c)",
r"import * as names from './named-exports'; console.log(names['a']);",
r"import * as foo from './bar'; foo.foo = 'y';",
r"import * as foo from './bar'; foo.x = 'y';",
r#"import * as names from "./named-exports"; const { c } = names"#,
r#"import * as names from "./named-exports"; function b() { const { c } = names }"#,
r#"import * as names from "./named-exports"; const { c: d } = names"#,
r#"import * as names from "./named-exports"; const { c: { d } } = names"#,
// r#"import * as Endpoints from "./issue-195/Endpoints"; console.log(Endpoints.Foo)"#,
// r#"import * as namespace from './malformed.js';"#,
// r#"import b from './deep/default'; console.log(b.e)"#,
r"console.log(names.c); import * as names from './named-exports';",
r"function x() { console.log(names.c) } import * as names from './named-exports';",
r#"import * as ree from "./re-export"; console.log(ree.default)"#,
r#"import * as Names from "./named-exports"; const Foo = <Names.e/>"#,
// r#"import { "b" as b } from "./deep/a"; console.log(b.e)"#,
// r#"import { "b" as b } from "./deep/a"; console.log(b.c.e)"#,
// r#"import * as a from "./deep/a"; console.log(a.b.e)"#,
// r#"import { b } from "./deep/a"; console.log(b.e)"#,
// r#"import * as a from "./deep/a"; console.log(a.b.c.e)"#,
// r#"import { b } from "./deep/a"; console.log(b.c.e)"#,
// r#"import * as a from "./deep/a"; var {b:{ e }} = a"#,
// r#"import * as a from "./deep/a"; var {b:{c:{ e }}} = a"#,
// r#"import * as a from "./deep-es7/a"; console.log(a.b.e)"#,
// r#"import { b } from "./deep-es7/a"; console.log(b.e)"#,
// r#"import * as a from "./deep-es7/a"; console.log(a.b.c.e)"#,
// r#"import { b } from "./deep-es7/a"; console.log(b.c.e)"#,
// r#"import * as a from "./deep-es7/a"; var {b:{ e }} = a"#,
// r#"import * as a from "./deep-es7/a"; var {b:{c:{ e }}} = a"#,
];
Tester::new(Namespace::NAME, pass, fail)
.change_rule_path("index.js")
.with_import_plugin(true)
.test_and_snapshot();
}