-
-
Notifications
You must be signed in to change notification settings - Fork 337
/
no_duplicates.rs
335 lines (315 loc) · 12.1 KB
/
no_duplicates.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
use itertools::Itertools;
use oxc_diagnostics::miette::{miette, LabeledSpan, Severity};
use oxc_macros::declare_oxc_lint;
use oxc_syntax::module_record::{ImportImportName, RequestedModule};
use crate::{context::LintContext, rule::Rule};
/// <https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-duplicates.md>
#[derive(Debug, Default, Clone)]
pub struct NoDuplicates {
prefer_inline: bool,
}
declare_oxc_lint!(
/// ### What it does
///
/// Reports if a resolved path is imported more than once.
NoDuplicates,
suspicious
);
impl Rule for NoDuplicates {
fn from_configuration(value: serde_json::Value) -> Self {
Self {
prefer_inline: value
.get("preferInline")
.and_then(serde_json::Value::as_bool)
.unwrap_or(false),
}
}
fn run_once(&self, ctx: &LintContext<'_>) {
let module_record = ctx.semantic().module_record();
let groups = module_record
.requested_modules
.iter()
.map(|(source, requested_modules)| {
let resolved_absolute_path = module_record.loaded_modules.get(source).map_or_else(
|| source.to_string(),
|module| module.resolved_absolute_path.to_string_lossy().to_string(),
);
(resolved_absolute_path, requested_modules)
})
.group_by(|r| r.0.clone());
let check_duplicates = |requested_modules: Option<&Vec<&RequestedModule>>| {
if let Some(requested_modules) = requested_modules {
if requested_modules.len() > 1 {
let labels = requested_modules
.iter()
.map(|requested_module| LabeledSpan::underline(requested_module.span()))
.collect::<Vec<_>>();
ctx.diagnostic(miette!(
severity = Severity::Warning,
labels = labels,
"eslint-plugin-import(no-duplicates): Forbid repeated import of the same module in multiple places"
));
}
}
};
for (_path, group) in &groups {
let has_type_import = module_record.import_entries.iter().any(|entry| entry.is_type);
// When prefer_inline is false, 0 is value, 1 is type named, 2 is type default or type namespace
// When prefer_inline is true, 0 is value and type named, 2 is type default or type namespace
let import_entries_maps = group
.into_iter()
.flat_map(|(_path, requested_modules)| requested_modules)
.into_group_map_by(|requested_module| {
// We should early return if there is no type import
if !has_type_import {
return 0;
};
for entry in &module_record.import_entries {
if entry.module_request.span() != requested_module.span() {
continue;
}
if entry.is_type {
return match entry.import_name {
ImportImportName::Name(_) => i8::from(!self.prefer_inline),
ImportImportName::NamespaceObject
| ImportImportName::Default(_) => 2,
};
}
}
0
});
check_duplicates(import_entries_maps.get(&0));
check_duplicates(import_entries_maps.get(&1));
check_duplicates(import_entries_maps.get(&2));
}
}
}
#[test]
fn test() {
use crate::tester::Tester;
use serde_json::json;
let pass = vec![
(r#"import "./malformed.js""#, None),
(r"import { x } from './foo'; import { y } from './bar'", None),
(r#"import foo from "234artaf"; import { shoop } from "234q25ad""#, None),
// r#"import { x } from './foo'; import type { y } from './foo'"#,
// TODO: considerQueryString
// r#"import x from './bar?optionX'; import y from './bar?optionY';"#,
(r"import x from './foo'; import y from './bar';", None),
// TODO: separate namespace
// r#"import * as ns from './foo'; import {y} from './foo'"#,
// r#"import {y} from './foo'; import * as ns from './foo'"#,
// TypeScript
(r"import type { x } from './foo'; import y from './foo'", None),
(r"import type x from './foo'; import type y from './bar'", None),
(r"import type {x} from './foo'; import type {y} from './bar'", None),
(r"import type x from './foo'; import type {y} from './foo'", None),
(
r"import type {} from './module';
import {} from './module2';",
None,
),
(
r"import type { Identifier } from 'module';
declare module 'module2' {
import type { Identifier } from 'module';
}
declare module 'module3' {
import type { Identifier } from 'module';
}",
None,
),
(r"import { type x } from './foo'; import y from './foo'", None),
(r"import { type x } from './foo'; import { y } from './foo'", None),
(r"import { type x } from './foo'; import type y from 'foo'", None),
];
let fail = vec![
(r"import { x } from './foo'; import { y } from './foo'", None),
(r"import {x} from './foo'; import {y} from './foo'; import { z } from './foo'", None),
// TODO: settings: { 'import/resolve': { paths: [path.join(process.cwd(), 'tests', 'files')], }, },
// r#"import { x } from './bar'; import { y } from 'bar';"#,
(r"import x from './bar.js?optionX'; import y from './bar?optionX';", None),
(r"import x from './bar?optionX'; import y from './bar?optionY';", None),
(r"import x from './bar?optionX'; import y from './bar.js?optionX';", None),
(r"import foo from 'non-existent'; import bar from 'non-existent';", None),
(r"import type { x } from './foo'; import type { y } from './foo'", None),
(r"import './foo'; import './foo'", None),
(
r"import { x, /* x */ } from './foo'; import {//y
y//y2
} from './foo'",
None,
),
(r"import {x} from './foo'; import {} from './foo'", None),
(r"import {a} from './foo'; import { a } from './foo'", None),
(
r"import {a,b} from './foo'; import { b, c } from './foo'; import {b,c,d} from './foo'",
None,
),
(r"import {a} from './foo'; import { a/*,b*/ } from './foo'", None),
(r"import {a} from './foo'; import { a } from './foo'", None),
(
r"import {a,b} from './foo'; import { b, c } from './foo'; import {b,c,d} from './foo'",
None,
),
(r"import {a} from './foo'; import { a/*,b*/ } from './foo'", None),
(
r"import {x} from './foo'; import {} from './foo'; import {/*c*/} from './foo'; import {y} from './foo'",
None,
),
(r"import { } from './foo'; import {x} from './foo'", None),
(r"import './foo'; import {x} from './foo'", None),
(r"import'./foo'; import {x} from './foo'", None),
(
r"import './foo'; import { /*x*/} from './foo'; import {//y
} from './foo'; import {z} from './foo'",
None,
),
(r"import './foo'; import def, {x} from './foo'", None),
(r"import './foo'; import def from './foo'", None),
(r"import def from './foo'; import {x} from './foo'", None),
(r"import {x} from './foo'; import def from './foo'", None),
(r"import{x} from './foo'; import def from './foo'", None),
(r"import {x} from './foo'; import def, {y} from './foo'", None),
(r"import * as ns1 from './foo'; import * as ns2 from './foo'", None),
(r"import * as ns from './foo'; import {x} from './foo'; import {y} from './foo'", None),
(
r"import {x} from './foo'; import * as ns from './foo'; import {y} from './foo'; import './foo'",
None,
),
(
r"// some-tool-disable-next-line
import {x} from './foo'
import {//y
y} from './foo'",
None,
),
(
r"import {x} from './foo'
// some-tool-disable-next-line
import {y} from './foo'",
None,
),
(
r"import {x} from './foo' // some-tool-disable-line
import {y} from './foo'",
None,
),
(
r"import {x} from './foo'
import {y} from './foo' // some-tool-disable-line",
None,
),
(
r"import {x} from './foo'
/* comment */ import {y} from './foo'",
None,
),
(
r"import {x} from './foo'
import {y} from './foo' /* comment
multiline */",
None,
),
(
r"import {x} from './foo'
import {y} from './foo'
// some-tool-disable-next-line",
None,
),
(
r"import {x} from './foo'
// comment
import {y} from './foo'",
None,
),
(
r"import {x} from './foo'
import/* comment */{y} from './foo'",
None,
),
(
r"import {x} from './foo'
import/* comment */'./foo'",
None,
),
(
r"import {x} from './foo'
import{y}/* comment */from './foo'",
None,
),
(
r"import {x} from './foo'
import{y}from/* comment */'./foo'",
None,
),
(
r"import {x} from
// some-tool-disable-next-line
'./foo'
import {y} from './foo'",
None,
),
(
r"import { Foo } from './foo';
import { Bar } from './foo';
export const value = {}",
None,
),
(
r"import { Foo } from './foo';
import Bar from './foo';
export const value = {}",
None,
),
(
r"import {
DEFAULT_FILTER_KEYS,
BULK_DISABLED,
} from '../constants';
import React from 'react';
import {
BULK_ACTIONS_ENABLED
} from '../constants';
const TestComponent = () => {
return <div>
</div>;
}
export default TestComponent;",
None,
),
(
r"import {A1,} from 'foo';
import {B1,} from 'foo';
import {C1,} from 'foo';
import {
A2,
} from 'bar';
import {
B2,
} from 'bar';
import {
C2,
} from 'bar';",
None,
),
// TypeScript
(r"import type x from './foo'; import type y from './foo'", None),
(r"import type x from './foo'; import type x from './foo'", None),
(r"import type {x} from './foo'; import type {y} from './foo'", None),
(r"import {type x} from './foo'; import type {y} from './foo'", None),
(r"import {type x} from 'foo'; import type {y} from 'foo'", None),
(r"import {type x} from 'foo'; import type {y} from 'foo'", None),
(r"import {type x} from './foo'; import {type y} from './foo'", None),
(r"import {type x} from './foo'; import {type y} from './foo'", None),
(r"import {AValue, type x, BValue} from './foo'; import {type y} from './foo'", None),
(
r"import {AValue} from './foo'; import type {AType} from './foo'",
Some(json!({ "preferInline": true })),
),
];
Tester::new(NoDuplicates::NAME, pass, fail)
.change_rule_path("index.ts")
.with_import_plugin(true)
.test_and_snapshot();
}