☂️ eslint-plugin-jsx-a11y #1141

Boshen · 2023-11-04T01:03:46Z

Warning

This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules

This is tracking issue for eslint-plugin-jsx-a11y.

There are 36(+ 3 deprecated) rules.

8/31 recommended rules are remaining as TODO
2/5 not recommended rules are remaining as TODO

To get started, run the following command:

just new-jsx-a11y-rule <RULE_NAME>

Then register the rule in crates/oxc_linter/src/rules.rs and also declare_all_lint_rules at the bottom.

Recommended rules

✨: 23, 🚫: 0 / total: 31

Status	Name	Docs
✨	jsx-a11y/alt-text	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/alt-text.md
✨	jsx-a11y/anchor-has-content	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/anchor-has-content.md
✨	jsx-a11y/anchor-is-valid	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/anchor-is-valid.md
✨	jsx-a11y/aria-activedescendant-has-tabindex	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/aria-activedescendant-has-tabindex.md
✨	jsx-a11y/aria-props	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/aria-props.md
	jsx-a11y/aria-proptypes	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/aria-proptypes.md
✨	jsx-a11y/aria-role	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/aria-role.md
✨	jsx-a11y/aria-unsupported-elements	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/aria-unsupported-elements.md
✨	jsx-a11y/autocomplete-valid	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/autocomplete-valid.md
✨	jsx-a11y/click-events-have-key-events	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/click-events-have-key-events.md
✨	jsx-a11y/heading-has-content	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/heading-has-content.md
✨	jsx-a11y/html-has-lang	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/html-has-lang.md
✨	jsx-a11y/iframe-has-title	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/iframe-has-title.md
✨	jsx-a11y/img-redundant-alt	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/img-redundant-alt.md
	jsx-a11y/interactive-supports-focus	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/interactive-supports-focus.md
	jsx-a11y/label-has-associated-control	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/label-has-associated-control.md
✨	jsx-a11y/media-has-caption	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/media-has-caption.md
✨	jsx-a11y/mouse-events-have-key-events	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/mouse-events-have-key-events.md
✨	jsx-a11y/no-access-key	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-access-key.md
✨	jsx-a11y/no-autofocus	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-autofocus.md
✨	jsx-a11y/no-distracting-elements	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-distracting-elements.md
	jsx-a11y/no-interactive-element-to-noninteractive-role	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-interactive-element-to-noninteractive-role.md
	jsx-a11y/no-noninteractive-element-interactions	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-noninteractive-element-interactions.md
	jsx-a11y/no-noninteractive-element-to-interactive-role	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-noninteractive-element-to-interactive-role.md
	jsx-a11y/no-noninteractive-tabindex	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-noninteractive-tabindex.md
✨	jsx-a11y/no-redundant-roles	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-redundant-roles.md
	jsx-a11y/no-static-element-interactions	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-static-element-interactions.md
✨	jsx-a11y/role-has-required-aria-props	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/role-has-required-aria-props.md
✨	jsx-a11y/role-supports-aria-props	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/role-supports-aria-props.md
✨	jsx-a11y/scope	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/scope.md
✨	jsx-a11y/tabindex-no-positive	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/tabindex-no-positive.md

✨ = Implemented, 🚫 = Not supported

Not recommended rules

✨: 3, 🚫: 0 / total: 5

Status	Name	Docs
	jsx-a11y/anchor-ambiguous-text	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/anchor-ambiguous-text.md
	jsx-a11y/control-has-associated-label	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/control-has-associated-label.md
✨	jsx-a11y/lang	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/lang.md
✨	jsx-a11y/no-aria-hidden-on-focusable	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-aria-hidden-on-focusable.md
✨	jsx-a11y/prefer-tag-over-role	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/prefer-tag-over-role.md

✨ = Implemented, 🚫 = Not supported

Deprecated rules

✨: 0, 🚫: 0 / total: 3

Status	Name	Docs
	jsx-a11y/accessible-emoji	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/accessible-emoji.md
	jsx-a11y/label-has-for	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/label-has-for.md
	jsx-a11y/no-onchange	https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-onchange.md

✨ = Implemented, 🚫 = Not supported

The text was updated successfully, but these errors were encountered:

Boshen · 2023-11-04T01:05:44Z

cc @manzt

msdlisper · 2023-11-18T15:14:45Z

@Boshen @manzt Can you assign me the task of anchor-has-content?

manzt · 2023-11-18T16:22:29Z

Feel free to make a PR and reference this issue!

It's my first time trying to implement the rule of linter. **html-has-lang** for #1141

Try to implement `heading-has-content` for #1141 .

…ss) (#1589) ## Summary partof: #1141 I re-implemented iframe-has-title rule for jsx_a11y in Rust same as the original JS one, and moved also the test related to the rule to here. originals: - doc: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/iframe-has-title.md - code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/iframe-has-title.js - test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/iframe-has-title-test.js

## Summary partof: #1141 I re-implemented scope rule for jsx_a11y in Rust same as the original JS one, and moved also the test related to the rule to here. originals: - doc: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/scope.md - code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/scope.js - test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/scope-test.js

impl linter for #1141

JustFly1984 · 2023-12-10T08:46:04Z

This plugin is a great, though nobody maintains eslint plugin for a long time.

partof: #1141 I've implemented `tabindex-no-positive` rule for jsx_a11y originals: - doc: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/tabindex-no-positive.md - code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/tabindex-no-positive.js - test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/tabindex-no-positive-test.js

When we developed linter for #1141 , we needed to configure some settings for `jsx-a11y`, which was not supported before, but I am trying to support it now. like this: ``` fn config() -> serde_json::Value { serde_json::json!([2,{ "ignoreNonDOM": true }]) } fn settings() -> serde_json::Value { serde_json::json!({ "jsx-a11y": { "components": { "Button": "button", } } }) } let pass = vec![ ("<Button />", Some(config()), Some(settings())), ]; ```

…1708) partof: #1141 I've implemented `no-access-key` rule for jsx_a11y originals: - doc: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/no-access-key.md - code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/no-access-key.js - test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/no-access-key-test.js

Shinyaigeek · 2023-12-28T18:34:08Z

What do you want to benefit from it? Are biome_aria slow?

biome_aria looks totally different from aria-query. aria-query has the data not only about aria but also about DOM elements, but biome_aria does not. I interpret that biome_aria is made to aggregate just the aria related data for biome (maybe specieally for biome’s linter), and is not alternative of aria-query, so it’s API is different.

Considering that oxc will provide an interface for linter plugins defined in userland in the future, I believe that it is advantageous from the viewpoint of easy transition and ecosystem development to provide not only aria data but also dom elements and other data for such users, and to provide an API equivalent to aria-query (but just in my opinion).

XantreDev · 2023-12-28T23:43:05Z

Maybe, I've just seen that biome uses biome_aria for aria jsx rules. https://github.com/biomejs/biome/blob/b99e7856e99d656675d688d75a875570382f9c71/crates/biome_js_analyze/src/aria_analyzers/a11y/use_aria_props_for_role.rs#L49

eslint-plugin-jsx-a11y aria-role for #1141

…rrectness) (#1867) Part of #1141 Based on: - https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/mouse-events-have-key-events.md - https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/mouse-events-have-key-events.js

Part of: #1141 Based on - doc: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/prefer-tag-over-role.md - code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/prefer-tag-over-role.js - test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/prefer-tag-over-role-test.js

## Summary partof: #1141 I re-implemented role-support-aria-props rule for jsx_a11y. originals: - docs: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/role-supports-aria-props.md - code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/role-supports-aria-props.js - test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/role-supports-aria-props-test.js

) partof: #1141 Based on: - doc: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/role-has-required-aria-props.md - code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/role-has-required-aria-props.js - test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/role-has-required-aria-props-test.js

Part of: #1141 Based on: - doc: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/autocomplete-valid.md - code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/autocomplete-valid.js - test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/autocomplete-valid-test.js

keita-hino · 2024-01-11T09:06:41Z

I will start working on the task of aria-activedescendant-has-tabindex.

) ( #1974 was lost due to mishandling. 🙈 ) Part of #1141 ### Refs - https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/4c7e7815c12a797587bb8e3cdced7f3003848964/docs/rules/click-events-have-key-events.md - https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/4c7e7815c12a797587bb8e3cdced7f3003848964/src/rules/click-events-have-key-events.js - https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/4c7e7815c12a797587bb8e3cdced7f3003848964/__tests__/src/rules/click-events-have-key-events-test.js --------- Co-authored-by: Boshen <boshenc@gmail.com>

…ex (#2012) Part of: #1141 Based on: - docs: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/aria-activedescendant-has-tabindex.md - code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/aria-activedescendant-has-tabindex.js - test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/aria-activedescendant-has-tabindex-test.js

Part of: #1141 Based on: - doc: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/no-redundant-roles.md - code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/no-redundant-roles.js - test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/no-redundant-roles-test.js

regexyl · 2024-01-16T04:42:27Z

I've started implementation for label-has-associated-control, but it looks like they're still a couple of kinks to work out for the original implementation:

I'll try jumping over there and see if there's anything I can help out with before looping back here :)

perfect the scope linter for #1141

Enables the case where `settings` is used. Part of #1141

Boshen mentioned this issue Nov 4, 2023

Linter Product Plan and Progress #481

Open

Boshen changed the title ~~https://github.com/jsx-eslint/eslint-plugin-jsx-a11y (recommended)~~ ☂️ linter: eslint-plugin-jsx-a11y recommended rules (recommended) Nov 4, 2023

Boshen changed the title ~~☂️ linter: eslint-plugin-jsx-a11y recommended rules (recommended)~~ ☂️ linter: eslint-plugin-jsx-a11y recommended rules Nov 4, 2023

Boshen added A-linter Area - Linter good first issue Experience Level - Good for newcomers labels Nov 4, 2023

This comment was marked as resolved.

Sign in to view

msdlisper mentioned this issue Nov 19, 2023

feat(linter): anchor-has-content for eslint-plugin-jsx-a11y #1431

Merged

Ken-HH24 mentioned this issue Nov 19, 2023

feat(linter): html-has-lang for eslint-plugin-jsx-a11y #1436

Merged

Boshen pushed a commit that referenced this issue Nov 19, 2023

feat(linter): html-has-lang for eslint-plugin-jsx-a11y (#1436)

822ce76

It's my first time trying to implement the rule of linter. **html-has-lang** for #1141

msdlisper mentioned this issue Nov 21, 2023

feat(linter): anchor-is-valid for eslint-plugin-jsx-a11y #1477

Merged

Ken-HH24 mentioned this issue Nov 22, 2023

feat(linter): heading-has-content for eslint-plugin-jsx-a11y #1501

Merged

camc314 pushed a commit that referenced this issue Nov 23, 2023

feat(linter): heading-has-content for eslint-plugin-jsx-a11y (#1501)

ebf5cf8

Try to implement `heading-has-content` for #1141 .

This was referenced Nov 28, 2023

feat(linter): eslint-plugin-jsx-a11y img-redundant-alt (correctness) #1571

Merged

feat(linter): eslint-plugin-jsx-a11y iframe-has-title rule (correctness) #1589

Merged

feat(linter): eslint-plugin-jsx-a11y scope rule (correctness) #1609

Merged

msdlisper mentioned this issue Dec 7, 2023

feat(linter): eslint-plugin-jsx-a11y no-autofocus #1641

Merged

Boshen pushed a commit that referenced this issue Dec 8, 2023

feat(linter): eslint-plugin-jsx-a11y no-autofocus (#1641)

d88f4f4

impl linter for #1141

msdlisper mentioned this issue Dec 13, 2023

feat(linter): add jsx-a11y settings #1668

Merged

yoshi2no mentioned this issue Dec 14, 2023

feat(linter): tabindex-no-positive for eslint-plugin-jsx-a11y #1677

Merged

yoshi2no mentioned this issue Dec 17, 2023

feat(linter): no-access-key for eslint-plugin-jsx-a11y #1708

Merged

tapanprakasht mentioned this issue Dec 21, 2023

feat(linter): eslint-plugin-jsx-a11y no-distracting-elements rule #1767

Merged

camc314 pushed a commit that referenced this issue Dec 29, 2023

feat(linter): eslint plugin jsx a11y: aria-role (#1849)

af61894

eslint-plugin-jsx-a11y aria-role for #1141

re-taro mentioned this issue Dec 29, 2023

feat(linter): eslint-plugin-jsx-a11y: aria-unsupported-elements #1855

Merged

Ken-HH24 mentioned this issue Jan 1, 2024

feat(linter): eslint-plugin-jsx-a11y mouse-events-have-key-events(correctness) #1867

Merged

yossydev mentioned this issue Jan 3, 2024

feat(linter): eslint-plugin-jsx-a11y role-has-required-aria-props rule #1881

Merged

re-taro mentioned this issue Jan 8, 2024

feat(linter): eslint-plugin-jsx-a11y role-support-aria-props #1949

Merged

re-taro mentioned this issue Jan 9, 2024

feat(linter): eslint-plugin-jsx-a11y role-support-aria-props #1961

Merged

yossydev mentioned this issue Jan 10, 2024

feat(linter): eslint-plugin-jsx-a11y autocomplete-valid #1901

Merged

leaysgur mentioned this issue Jan 10, 2024

feat(linter): eslint-plugin-jsx-a11y click-events-have-key-events #1974

Closed

11 tasks

leaysgur mentioned this issue Jan 10, 2024

feat(linter): eslint-plugin-jsx-a11y click-events-have-key-events #1976

Merged

yossydev mentioned this issue Jan 10, 2024

feat(linter): eslint-plugin-jsx-a11y no-redundant-roles rule #1981

Merged

keita-hino mentioned this issue Jan 13, 2024

feat(linter): eslint-plugin-jsx-a11y aria-activedescendant-has-tabindex #2012

Merged

msdlisper mentioned this issue Jan 19, 2024

refactor(linter): perfect the scope linter #2092

Merged

Dunqing pushed a commit that referenced this issue Jan 20, 2024

refactor(linter): perfect the scope linter (#2092)

a368134

perfect the scope linter for #1141

msdlisper mentioned this issue Jan 21, 2024

refactor(linter): complete img-redundant linter #2112

Merged

camc314 pushed a commit that referenced this issue Jan 21, 2024

fix(linter): jsx_a11y/img-redundant linter enable test case(#2112)

2228aa8

Enables the case where `settings` is used. Part of #1141

Boshen changed the title ~~☂️ linter: eslint-plugin-jsx-a11y recommended rules~~ ☂️ eslint-plugin-jsx-a11y Jan 26, 2024

jelly mentioned this issue Apr 9, 2024

Consider oxlint as replacement of eslint cockpit-project/cockpit#20279

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

☂️ eslint-plugin-jsx-a11y #1141

☂️ eslint-plugin-jsx-a11y #1141

Boshen commented Nov 4, 2023 •

edited by github-actions bot

Boshen commented Nov 4, 2023

This comment was marked as resolved.

msdlisper commented Nov 18, 2023

manzt commented Nov 18, 2023

JustFly1984 commented Dec 10, 2023

Shinyaigeek commented Dec 28, 2023 •

edited

XantreDev commented Dec 28, 2023

keita-hino commented Jan 11, 2024

regexyl commented Jan 16, 2024

☂️ eslint-plugin-jsx-a11y #1141

☂️ eslint-plugin-jsx-a11y #1141

Comments

Boshen commented Nov 4, 2023 • edited by github-actions bot

Recommended rules

Not recommended rules

Deprecated rules

Boshen commented Nov 4, 2023

This comment was marked as resolved.

msdlisper commented Nov 18, 2023

manzt commented Nov 18, 2023

JustFly1984 commented Dec 10, 2023

Shinyaigeek commented Dec 28, 2023 • edited

XantreDev commented Dec 28, 2023

keita-hino commented Jan 11, 2024

regexyl commented Jan 16, 2024

Boshen commented Nov 4, 2023 •

edited by github-actions bot

Shinyaigeek commented Dec 28, 2023 •

edited