improvement(linter/oxc): using facades for barrel detections. #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3215 will not alter performanceComparing Summary
|
rzvxa
force-pushed
the
05-09-improvement_linter_oxc_using_facades_for_barrel_detections
branch
from
bdb6fb6
to
9e07df8
Compare
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Boshen
reviewed
May 9, 2024
|
|
||
| fn run(&self, node: &AstNode<'_>, ctx: &LintContext<'_>) { | ||
| let AstKind::ImportDeclaration(import) = node.kind() else { return }; | ||
| if is_facade_import(ctx.file_path().to_str().unwrap(), import.source.value.as_str()) { |
There was a problem hiding this comment.
I can simplify this, leave this to me.
There was a problem hiding this comment.
Feel free to take over this PR, I'll start working on other stuff. Let me know if there is anything you want me to change.
|
Now I understand what this is doing when it's written in Rust 😅 |
|
Closed in favor of #3275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3069
It is similar to this, I've dialed back some package resolving to make it more general, We might want to invest in creating a package resolver(let me know if we already have the infrastructure for it and I've missed it).