Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of possible unsound auto trait impl in the index_vec. #3096

Open
rzvxa opened this issue Apr 25, 2024 · 2 comments
Open

Use of possible unsound auto trait impl in the index_vec. #3096

rzvxa opened this issue Apr 25, 2024 · 2 comments
Labels
C-bug Category - Bug rust Pull requests that update Rust code

Comments

@rzvxa
Copy link
Collaborator

rzvxa commented Apr 25, 2024

This needs to be addressed in the future since Rust is breaking the compatibility for this one.

#3092 (comment)

@rzvxa rzvxa added C-bug Category - Bug rust Pull requests that update Rust code labels Apr 25, 2024
@rzvxa rzvxa assigned Boshen and unassigned Boshen Apr 25, 2024
@rzvxa rzvxa changed the title Use of possible unsound auto trait impl in indexed_vec. Use of possible unsound auto trait impl in index_vec. Apr 25, 2024
@rzvxa rzvxa changed the title Use of possible unsound auto trait impl in index_vec. Use of possible unsound auto trait impl in the index_vec. Apr 25, 2024
@Boshen
Copy link
Member

Boshen commented May 4, 2024

The clippy warning suspicious_auto_trait_impls is removed after the 1.78.0 upgrade. I'm not sure if there are more actionable items to this issue.

@rzvxa
Copy link
Collaborator Author

rzvxa commented May 4, 2024

The clippy warning suspicious_auto_trait_impls is removed after the 1.78.0 upgrade. I'm not sure if there are more actionable items to this issue.

To be honest I'm not sure ATM, The issue is that auto trait impls for Adt<Any> are going to be ignored.

The goal for this auto impl in the indexed_vec is to have the same Send/Sync as the inner T within a wrapped generic slice.
There might be other ways to approach it or we might not even need it since we are not advertising oxc_index as a general-purpose crate.

I've mostly created this issue so we can keep track of it, I didn't put that much thought into fixing it since we wanted to have a clean fork before doing any changes to it.

rust-lang/rust#113312
rust-lang/rust#93367 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category - Bug rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

2 participants