Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): eslint/no-import-assign (partially done, in nursery category) #610

Closed
Tracked by #479
DonIsaac opened this issue Jul 25, 2023 · 8 comments · Fixed by #2617
Closed
Tracked by #479

feat(linter): eslint/no-import-assign (partially done, in nursery category) #610

DonIsaac opened this issue Jul 25, 2023 · 8 comments · Fixed by #2617
Assignees
Labels
A-linter Area - Linter good first issue Experience Level - Good for newcomers

Comments

@DonIsaac
Copy link
Collaborator

DonIsaac commented Jul 25, 2023

Implement ESLint's no-import-assign rule.

To get started, run

just new-rule no-import-assign
@DonIsaac DonIsaac added good first issue Experience Level - Good for newcomers A-linter Area - Linter labels Jul 25, 2023
@DonIsaac DonIsaac changed the title no-import-assign (partially done, in nursery category) feat(linter): eslint/no-import-assign (partially done, in nursery category) Jul 25, 2023
@DeividAlmeida
Copy link
Contributor

hi, i want to continue this rule, but i saw that it's implemented, what can i do to conclude ?

@mysteryven
Copy link
Member

hi, i want to continue this rule, but i saw that it's implemented, what can i do to conclude ?

There are some cases that are not supported yet, we can try to pass more!

@DeividAlmeida
Copy link
Contributor

the main problem is some references at fail test are flagged as 'Read' and all read are passing without warning.

image

@DeividAlmeida
Copy link
Contributor

should i open a else block to deal with a Read end ReadWrite flag in no_import_assign.rs?

@DeividAlmeida
Copy link
Contributor

what approach do you suggest in this case?

@Boshen
Copy link
Member

Boshen commented Jan 17, 2024

should i open a else block to deal with a Read end ReadWrite flag in no_import_assign.rs?

You may give it a try 😁

@DeividAlmeida
Copy link
Contributor

To improve this should improve all its references like @Boshen said here #2164

@Boshen
Copy link
Member

Boshen commented Mar 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter good first issue Experience Level - Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants