Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataStore::sled_upsert returns a confusing error when upserting a decommissioned sled #5708

Open
jgallagher opened this issue May 6, 2024 · 0 comments

Comments

@jgallagher
Copy link
Contributor

The docs for sled_upsert note that attempting to upsert a decommissioned sled will fail, but the error it returns in such a case is confusing:

InternalError { internal_message: "Unknown diesel error creating Sled called \"d2de48dd-e9b2-4d5f-ac8c-d5ff0a97997d\": Record not found" }

I think the "Record not found" is coming because we filter on the state not being decommissioned, but we should map this to a more descriptive error than "unknown diesel error".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant