Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chan(*): normalize script names #1098

Merged
merged 9 commits into from
May 6, 2024
Merged

Conversation

D-Brox
Copy link
Contributor

@D-Brox D-Brox commented May 2, 2024

Purpose

We don't need the files to have *-local.sh.

Approach

Renames download.sh to get-pacscript.sh and download-local.sh to fetch-sources.sh, as it is more descriptive.
Renames install-local.sh to package.sh, since the -B flag exists.
Renames error_log.sh to error-log.sh, an almost 3 year old mistake by me (in #146)
Renames build-local.sh to build.sh because the -local is redundant.

Replaces all mentions to the filenames in the code

Progress

Done

Checklist

  • I confirm that I have read the contributing guidelines, and this pull request is abiding by all the clauses stated in the guideline.

misc/scripts/update.sh Outdated Show resolved Hide resolved
@oklopfer oklopfer changed the title Change: normalize script names chan(*): normalize script names May 5, 2024
Copy link
Member

@oklopfer oklopfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also do:

shfmt -bn -ci -sr -s -i 4 -w pacstall misc/scripts/*.sh
chmod +x misc/scripts/*.sh

feel free to say no and save it for the next PR, but it should be the next thing to be done

@D-Brox D-Brox requested a review from oklopfer May 5, 2024 23:28
@oklopfer oklopfer merged commit dc4e076 into pacstall:develop May 6, 2024
4 checks passed
@D-Brox D-Brox deleted the chan/filenames branch May 6, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants