Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript version for v7 #410

Closed
vldslv-a opened this issue Apr 12, 2024 · 2 comments · Fixed by #417
Closed

Update typescript version for v7 #410

vldslv-a opened this issue Apr 12, 2024 · 2 comments · Fixed by #417

Comments

@vldslv-a
Copy link

I get an error after installing madge v7:

⠋ Finding files=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.2.0

YOUR TYPESCRIPT VERSION: 5.4.5

Please only submit bug reports when using the officially supported version.

=============

✖ TypeError: Cannot read properties of undefined (reading 'filter')
at tsLookup (/usr/local/lib/node_modules/madge/node_modules/filing-cabinet/index.js:263:8)
at module.exports (/usr/local/lib/node_modules/madge/node_modules/filing-cabinet/index.js:74:18)
at module.exports._getDependencies (/usr/local/lib/node_modules/madge/node_modules/dependency-tree/index.js:100:20)
at traverse (/usr/local/lib/node_modules/madge/node_modules/dependency-tree/index.js:146:37)
at traverse (/usr/local/lib/node_modules/madge/node_modules/dependency-tree/index.js:170:29)
at module.exports (/usr/local/lib/node_modules/madge/node_modules/dependency-tree/index.js:37:19)
at /usr/local/lib/node_modules/madge/lib/tree.js:121:27
at Array.forEach ()
at Tree.generateTree (/usr/local/lib/node_modules/madge/lib/tree.js:116:9)

Could you please fix ts support in the near future?

@Jym77
Copy link

Jym77 commented Apr 30, 2024

$ yarn why -R @typescript-eslint/typescript-estree
└─ @siteimprove/alfa@workspace:.
   └─ madge@npm:7.0.0 [f3970] (via npm:^7.0.0 [f3970])
      ├─ dependency-tree@npm:10.0.9 (via npm:^10.0.9)
      │  └─ precinct@npm:11.0.5 (via npm:^11.0.5)
      │     └─ detective-typescript@npm:11.2.0 (via npm:^11.1.0)
      │        └─ @typescript-eslint/typescript-estree@npm:5.62.0 [160ad] (via npm:^5.62.0 [160ad])
      └─ precinct@npm:11.0.5 (via npm:^11.0.5)

typescript-eslint is now at version 7.8.0: https://github.com/typescript-eslint/typescript-eslint/tags

It seems to be precinct which is holding madge back, it is now at version 12.1.1 with, I guess, an update typescript-eslint since it depends on TS 5.4.5: https://github.com/dependents/node-precinct/blob/main/package.json#L59

So, I guess it is a matter of updating precinct, OTOH it is also included through dependency-tree which has the same outdated version.

@fdc-viktor-luft
Copy link
Collaborator

This was released now, which should fix that issue:

https://github.com/dependents/node-dependency-tree/releases/tag/v11.0.0

@fdc-viktor-luft fdc-viktor-luft linked a pull request May 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants