Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add an option to delay screenshot being sent to Discord #339

Open
UmaLPZ opened this issue Oct 19, 2023 · 8 comments · May be fixed by #390
Open

Feature Request: Add an option to delay screenshot being sent to Discord #339

UmaLPZ opened this issue Oct 19, 2023 · 8 comments · May be fixed by #390
Labels
needs discussion Discussion is required on whether the requested feature should be added Notifier: Loot

Comments

@UmaLPZ
Copy link

UmaLPZ commented Oct 19, 2023

Love the plugin and thank you for adding the npc kill count to the loot notifications.

Is it possible to add an option to delay the notification from being sent to Discord or does this option already exist? I'm in a clan event right now and we use this plugin for backup screenshots for loot drops. Unfortunately, that involves having the loot notification that appears in chat also appear for the drop to count. The plugin will send the screenshot before the chat shows the drop, so we still have to manually take a screenshot. The plugin is helpful is still very helpful for keeping track of drops for the event regardless. An option to add a small 1 to 2 second delay would be appreciated.

Thank you.

Edit:
Looking at the drop notifications from fellow clan member, they would sometimes get the chat message in the screenshot but sometimes not. Not sure why it's inconsistent for them and for me it never shows the chat message.

@iProdigy
Copy link
Member

Could you specify which NPCs lead to loot screenshots that are too early, in your experience?

@UmaLPZ
Copy link
Author

UmaLPZ commented Nov 9, 2023

Could you specify which NPCs lead to loot screenshots that are too early, in your experience?

Ooops been out of town recently. It happened to me when killing vorkath, calvarion, demonic gorillas, and spiritual mages. Others in my clan had it happen at places like duke and the other dt2 bosses.

@iProdigy
Copy link
Member

Do you have Valuable drop chat notifications enabled? We're not able to reproduce this issue for vorkath/duke

https://i.ivr.fi/runelite/fae185d191e9.png
https://i.ivr.fi/runelite/538a5f12adbe.png

@Felanbird
Copy link
Member

My assumption was this problem was related to some other hub plugin or just general lag, I personally never have it for any boss except Whisperer, vorkath and duke never; pajlada did have it happen for a ring drop at dag kings but it was the opposite, he had already picked up the ring before the notif went off, not before.

@iProdigy
Copy link
Member

other dt2 bosses look good

https://i.ivr.fi/runelite/c30528f42146.png
https://i.ivr.fi/runelite/758c8dd4a076.png
https://i.ivr.fi/runelite/eb7a46acc79b.png

@UmaLPZ Are you expecting the clan loot notification to be in the screenshot instead of the valuable drop chat message? (the clan message has greater delay)

@UmaLPZ
Copy link
Author

UmaLPZ commented Nov 10, 2023

Yes, I have valuable drop chat notifications enabled and yes, the requirement was to have the clan loot notification also be in the screenshot. There was an issue with the Wise Old Man plugin that was causing some clients to crash so that might have had something to do with it. I don't know what other plugins may have caused an issue since not everyone in my clan has the same plugins installed. Some of the screenshots from my clan members do show higher ping than me but still get the screenshot to include the clan notification.

@iProdigy
Copy link
Member

Do your screenshots include the valuable drop chat message?

I'm apprehensive to delay loot notifs until the clan message arrives since it could be possible to grab the items before the clan message arrives, yielding a screenshot without the ground item present

@UmaLPZ
Copy link
Author

UmaLPZ commented Nov 10, 2023

Yes, they all include the valuable drop message. For the clan event we were allowed to post screenshots of the item in our inventory as long as we included the clan message and it was soon after the drop. We primarily needed the codeword displayed by Wise Old Man plugin and the clan message.

Would it be possible to have the delay be optional and adjustable? Since this doesn't affect the valuable drop message being left out and is only really needed for some users or clan events. The delay isn't needed overall, but it comes it makes clan events much easier to track.

@iProdigy iProdigy linked a pull request Dec 13, 2023 that will close this issue
@iProdigy iProdigy added the needs discussion Discussion is required on whether the requested feature should be added label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Discussion is required on whether the requested feature should be added Notifier: Loot
Projects
None yet
3 participants