Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include plaintext_env_vars in nginx-cnb #12

Open
kvedurmu opened this issue Apr 24, 2020 · 4 comments
Open

Include plaintext_env_vars in nginx-cnb #12

kvedurmu opened this issue Apr 24, 2020 · 4 comments
Projects

Comments

@kvedurmu
Copy link
Member

See this feature request in the CF NGINX Buildpack for context - cloudfoundry/nginx-buildpack#17. We should look into supporting this behavior in the NGINX Paketo Buildpack.

@kvedurmu
Copy link
Member Author

@ForestEckhardt could you update this issue to make it a bit more clear? Thanks.

@ryanmoran ryanmoran added this to To Do in PHP Apr 24, 2020
@ForestEckhardt
Copy link
Contributor

@kvedurmu I have as much context as that issue unfortunately.

@fg-j
Copy link

fg-j commented Nov 29, 2021

This test added to the cloud foundry buildpack in the commit that resolves the CF buildpack issue sheds some light on the expected behaviour of this feature and some potential reproduction steps.

To reproduce, I think we need to build this cloud foundry buildpack test fixture with the CNB and evaluate whether the /test endpoint returns proper JSON or not.

@ForestEckhardt
Copy link
Contributor

My understanding is that we are trying to move away from increased user interpolation in the nginx.conf and this seems antithetical to that idea. I would love to hear from my fellow @paketo-buildpacks/web-servers-maintainers and @ryanmoran about there feelings on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PHP
Inbox
Development

No branches or pull requests

3 participants