Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BP_WEB_SERVER_LOCATION_INCLUDES to Enable Custom Location Directives #668

Open
ChuckQuinnIV opened this issue Jan 26, 2024 · 2 comments
Labels
enhancement A new feature or request

Comments

@ChuckQuinnIV
Copy link

Describe the Enhancement

Add a new optional environment variable, BP_WEB_SERVER_LOCATION_INCLUDES (or similar) to allow users to provide location-scoped NGINX directives while taking advantage of the generated nginx.conf file.

Motivation

Users migrating from buildpacks like Cloud Foundry's Staticfile buildpack commonly only customize server root, push state, and location directives. Currently, users can use this buildpack with a generated nginx.conf using BP_WEB_SERVER_ENABLE_PUSH_STATE and BP_WEB_SERVER_ROOT for the first two features, but must maintain their own nginx.conf if they need any custom location directives. This proposed feature will remove the need for these users to eject from the generated nginx.conf.

@sophiewigmore
Copy link
Member

@paketo-buildpacks/web-servers-maintainers

@arjun024
Copy link
Member

I'd be open to a configuration that allows an include inside the default location block. PRs welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or request
Projects
Status: Not scoped
Development

No branches or pull requests

3 participants