Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BP_WEB_SERVER to a variable name that expresses behavior better #737

Open
Waterstraal opened this issue Apr 22, 2024 · 0 comments
Open

Rename BP_WEB_SERVER to a variable name that expresses behavior better #737

Waterstraal opened this issue Apr 22, 2024 · 0 comments

Comments

@Waterstraal
Copy link

The variable BP_WEB_SERVER will generate a default nginx.conf when the value is set to nginx. The variable name does not express this behavior, and is confusing in my opinion.

Describe the Enhancement

BP_WEB_SERVER is renamed to a more expressive variable name.

Possible Solution

BP_WEB_SERVER is renamed to a more expressive variable name such as:

  • BP_NGINX_GENERATE_DEFAULT_CONFIGURATION
  • BP_GENERATE_DEFAULT_NGINX_CONFIGURATION
  • BP_GENERATE_DEFAULT_WEBSERVER_CONFIGURATION
@Waterstraal Waterstraal changed the title Rename BP_WEB_SERVER variable to a variable name that expresses behavior better Rename BP_WEB_SERVER to a variable name that expresses behavior better Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Waterstraal