Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-pipeline.sh script is not working for v2 #1220

Open
dmikusa opened this issue Jul 19, 2023 · 0 comments
Open

update-pipeline.sh script is not working for v2 #1220

dmikusa opened this issue Jul 19, 2023 · 0 comments
Labels
type:bug A general bug

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Jul 19, 2023

Expected Behavior

When the update pipeline job runs, it sets the .github/pipeline-version file to the version of pipeline-builder that was used. It incorrectly selects the version for v2.

Current Behavior

It uses gh api to fetch the latest release, and uses the version number of the latest release. This is not accurate because what is the latest release is not tied to the code that has been checked out and is running.

Possible Solution

Look at the checked out branch and determine the version that way, like compute-version.sh.

Steps to Reproduce

paketo-buildpacks/pipeline-builder-stool-pigeon#4

Motivations

It should display accurate version information.

@dmikusa dmikusa added the type:bug A general bug label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant