Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Generations Workflow to have better error messages #1374

Open
dmikusa opened this issue Nov 13, 2023 · 3 comments
Open

Update Generations Workflow to have better error messages #1374

dmikusa opened this issue Nov 13, 2023 · 3 comments
Labels
note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:enhancement A general enhancement

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Nov 13, 2023

Expected Behavior

The update generations workflow runs to have better error messages when it fails.

Current Behavior

If it fails, like here https://github.com/paketo-buildpacks/spring-boot/actions/runs/6844922071/job/18627189425#step:4:7 the error messages are not helpful. Add more information to make it clear why it's failing when it fails.

Motivations

This allows the buildpack to provide guidance to users about the versions of Spring libraries they are using and if they are still supported.

@dmikusa dmikusa added the type:bug A general bug label Nov 13, 2023
@anthonydahanne
Copy link
Member

this issue will be resolved when this one is : spring-io/projects-api#18

we could meanwhile have better error reporting in https://github.com/paketo-buildpacks/pipeline-builder/blob/main/actions/spring-generations/main.go#L47

@anthonydahanne
Copy link
Member

this 500 is no longer happening
@dmikusa wanna keep this issue opened for improving the error message?

@dmikusa
Copy link
Contributor Author

dmikusa commented Nov 18, 2023

Yes, that sounds good. Moving to pipeline-builder as well.

@dmikusa dmikusa added type:enhancement A general enhancement note:ideal-for-contribution An issue that a contributor can help us with note:good-first-issue A good first issue to get started with and removed type:bug A general bug labels Nov 18, 2023
@dmikusa dmikusa changed the title Update Generations Workflow failing Update Generations Workflow to have better error messages Nov 18, 2023
@dmikusa dmikusa transferred this issue from paketo-buildpacks/spring-boot Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants