Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CGO_ENABLED to build.sh #1605

Open
dmikusa opened this issue May 13, 2024 · 0 comments
Open

Move CGO_ENABLED to build.sh #1605

dmikusa opened this issue May 13, 2024 · 0 comments
Labels
type:enhancement A general enhancement

Comments

@dmikusa
Copy link
Contributor

dmikusa commented May 13, 2024

Describe the Enhancement

Now that we control build.sh in pipeline-builder, we should add export CGO_ENABLED=0 to the build.sh script and remove it [from CI]https://github.com/paketo-buildpacks/liberty/blob/main/.github/workflows/pb-create-package.yml#L111-L116) so that things are more consistent outside of CI.

Motivation

Build consistency outside of CI.
@dmikusa dmikusa added the type:enhancement A general enhancement label May 13, 2024
@dmikusa dmikusa changed the title Move Move CGO_ENABLED to build.sh May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmikusa