Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delete_after_merge functionality #243

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

anishagg17
Copy link

Fixes: #212

removed code for attemptDelete and DeleteAfterMerge functionality

@palantirtech
Copy link
Member

Thanks for your interest in palantir/bulldozer, @anishagg17! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@asvoboda
Copy link
Member

Hey @anishagg17, thanks for the PR.

Do you mind also removing the examples as well?

delete_after_merge: true

https://github.com/palantir/bulldozer/blob/19a4b0800b00bab36aaf30366800f1016983efb5/README.md#bulldozeryml-specification

@anishagg17
Copy link
Author

sure, @asvoboda I have removed it from some tests too and even from the Readme

@anishagg17
Copy link
Author

anishagg17 commented Apr 23, 2021

Oh, I think that after changing the test config I need to make changes to the expected output also. Am I correct?

@asvoboda
Copy link
Member

If you run ./godelw verify locally, you can see the same output from the test.

It looks like the head var L158 in merge.go is now unused, and the compiler is complaining.

@anishagg17
Copy link
Author

It looks like the head var L158 in merge.go is now unused, and the compiler is complaining.

Yeah, replaced it with an _.

@anishagg17
Copy link
Author

@asvoboda can we merge this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove delete_after_merge option
3 participants