Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow digits in namespaces of type names #467

Open
JacekLach opened this issue Dec 10, 2019 · 0 comments
Open

Allow digits in namespaces of type names #467

JacekLach opened this issue Dec 10, 2019 · 0 comments

Comments

@JacekLach
Copy link

What happened?

types:
  conjure-imports:
    v1: v1.yml
  definitions:
    default-package: foo
    objects:
      Bar:
        fields:
          id: v1.BarId

results in an error:

java.lang.IllegalArgumentException: TypeNames must be a primitive type [any, string, integer, double, boolean, safelong, rid, bearertoken, uuid] or match pattern ^[A-Z][a-z0-9]+([A-Z][a-z0-9]+)*$: v1
        at com.google.common.base.Preconditions.checkArgument(Preconditions.java:455)
        at com.palantir.conjure.parser.types.names.TypeName.check(TypeName.java:46)
        at com.palantir.conjure.parser.types.names.ImmutableTypeName.validate(ImmutableTypeName.java:111)

What did you want to happen?

The namespace part of conjure imports is not externally visible and should not be subject to this regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant