Report request latency in default metrics #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in milliseconds by default, but can be changed by setting the zerolog.DurationFieldUnit variable, which also changes the unit used in request logs. For now, report a histogram of all requests, but it may make sense to split this out by status code in the future.
asvoboda
approved these changes
Jun 26, 2023
|
On a different internal PR, there's some discussion about units for time-based metrics and we're currently leaning towards adding an option to set the unit used when |
This will take advantage of the global timer unit configuration and also allows monitoring latency by status, as errors may be faster or slower than successful requests.
|
Updated to use |
asvoboda
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in milliseconds by default, but can be changed by setting the zerolog.DurationFieldUnit variable, which also changes the unit used in request logs. For now, report a histogram of all requests, but it may make sense to split this out by status code in the future.