Allow customizing timer units in Datadog export #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metrics.Timer type natively reports in nanoseconds, which is usually too small to be useful. Applications can now set the TimerUnits global variable to a different unit to scale values before they are sent to Datadog. We set the default value to nanoseconds for compatibility.
bluekeyes
commented
Jun 26, 2023
nvelat
approved these changes
Jun 27, 2023
bluekeyes
commented
Jun 27, 2023
| @@ -145,13 +156,13 @@ func (e *Emitter) EmitOnce() { | |||
|
|
|||
| case metrics.Timer: | |||
| ms := m.Snapshot() | |||
| _ = e.client.Gauge(name+".avg", ms.Mean(), tags, 1) | |||
| _ = e.client.Gauge(name+".avg", convertTime(ms.Mean()), tags, 1) | |||
| _ = e.client.Gauge(name+".count", float64(ms.Count()), tags, 1) | |||
There was a problem hiding this comment.
Count() returns a count of events, not a time, so it doesn't need conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
metrics.Timertype natively reports in nanoseconds, which is usually too small to be useful. Applications can now set theTimerUnitsglobal variable to a different unit to scale values before they are sent to Datadog. We set the default value to nanoseconds for compatibility.This may change how we report request latency in #181.