Add feature to ignore requests in logs/metrics #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had several requests to not log health check requests in apps built on baseapp and in general, these logs do clutter the log output and make finding "real" requests more difficult. This is less of a problem with metrics, but health check requests are still likely to inflate request counts and alter latency distributions. Instead of having some kind of complicated pattern-matching rule for paths, allow handlers to ignore requests on a per-request basis. For example, this means health check handlers could ignore all requests or only ignore successful requests.
asvoboda
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had several requests to not log health check requests in apps built on baseapp (e.g. palantir/policy-bot#172) and in general, these logs do clutter the log output and make finding "real" requests more difficult. This is less of a problem with metrics, but health check requests are still likely to inflate request counts and alter latency distributions.
Instead of having some kind of complicated pattern-matching rule for paths, allow handlers to ignore requests on a per-request basis. For example, this means health check handlers could ignore all requests or only ignore successful requests.