Add prometheus metrics emitter #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core of this package is a prometheus.Collector implementation that exposes the metrics of an rcrowley/go-metrics registry. It also provides a convenience function for creating a collector, registering it with a Prometheus registry, and exposing it on a HTTP endpoint. If you need to customize any of the Prometheus options, you can use the Collector directly. I ended up writing my own emitter because the existing exporters I found had some limitations: * Don't understand our custom tag/label format * Report at fixed intervals intead of implementing Collector * Export histograms incorrectly
asvoboda
approved these changes
Jul 4, 2023
|
Yeah, some basic tests would be good. I started writing some and discovered an issue with the Prometheus testing library, so I'm trying to decide how to best work around that. |
Per https://prometheus.io/docs/instrumenting/writing_exporters/, remove less useful statistics that can be computed in Prometheus, add simple help text to indicate the original metric type, add "seconds" to the names of timer metrics, and improve the santize function to avoid long runs of underscores.
|
Updated to add tests. I also made some other changes:
|
bluekeyes
force-pushed
the
bkeyes/prometheus-export
branch
from
e556def
to
e13ccd6
Compare
bluekeyes
force-pushed
the
bkeyes/prometheus-export
branch
from
e13ccd6
to
d0c128d
Compare
jamestoyer
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core of this package is a
prometheus.Collectorimplementation that exposes the metrics of anrcrowley/go-metricsregistry. It also provides a convenience function for creating a collector, registering it with a Prometheus registry, and exposing it on a HTTP endpoint. If you need to customize any of the Prometheus options, you can use the Collector directly.I ended up writing my own emitter because the existing exporters I found had some limitations:
CollectorBecause this is a new emitter, I tried to stay closer to Prometheus conventions rather than matching the Datadog emitter. Specifically:
go-metricsterminology0.5quantile instead of as a separate named metricBut I could be convinced it's better to match the Datadog emitter for easier migration.