Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page not found #170

Open
tekumara opened this issue Jul 17, 2022 · 2 comments
Open

404 page not found #170

tekumara opened this issue Jul 17, 2022 · 2 comments

Comments

@tekumara
Copy link

tekumara commented Jul 17, 2022

when creating a github app on github.com for the example and running:

go run ./example

web hook delivery fails with 404 page not found

@tekumara
Copy link
Author

tekumara commented Jul 17, 2022

Looks like this because of the line:

http.Handle(githubapp.DefaultWebhookRoute, handler)

which expects requests at /api/github/hook whereas my app on github.com was configured to post to /.

This makes it work:

http.Handle("/", handler)

@asvoboda
Copy link
Member

Hey @tekumara,

As you noticed, this is expected based on the code. I think we need to update our docs to reflect that you should point the github app's webhook configuration to myapp.domain/api/github/hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants