Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrepareRepoContext should take an interface #75

Open
bluekeyes opened this issue Mar 31, 2021 · 0 comments
Open

PrepareRepoContext should take an interface #75

bluekeyes opened this issue Mar 31, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@bluekeyes
Copy link
Member

bluekeyes commented Mar 31, 2021 •
edited

go-githubapp/githubapp/context.go

Line 35 in e6f4865

func PrepareRepoContext(ctx context.Context, installationID int64, repo *github.Repository) (context.Context, zerolog.Logger) {

go-github has a variety of repository-like objects, notably Repository and PushEventRepository. Since PrepareRepoContext only cares about a few fields accessed via getters, we should define an interface to accommodate the various repository objects.

We should use the same interface in PreparePRContext.
@bluekeyes bluekeyes added the enhancement New feature or request label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bluekeyes