Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download output breaks ./godelw project-version #400

Open
ajlake opened this issue Jun 5, 2018 · 3 comments
Open

Download output breaks ./godelw project-version #400

ajlake opened this issue Jun 5, 2018 · 3 comments
Labels

Comments

@ajlake
Copy link

ajlake commented Jun 5, 2018

I rely on tricks this like:

export VERSION=$(./godelw project-version)

This isn't reliable anymore because godel/plugin download information is sent to stdout:

{
  "version": "Downloading https://palantir.bintray.com/releases/com/palantir/godel/godel/1.2.0/godel-1.2.0.tgz to /home/circleci/.godel/downloads/godel-1.2.0.tgz...
0.0.0-9-g0083660"
}

Some ideas:

  • send to stderr
  • offer a -q/--quiet flag
  • suppress that output when running project-version
@ajlake ajlake added the bug label Jun 5, 2018
@nmiyake
Copy link
Contributor

nmiyake commented Jun 5, 2018

Looks like this output is part of the godelw script itself. I think that having this output go to stderr rather than stdout is reasonable -- the output is purely informational so don't think it's important for it to go to stdout necessarily.

@jmcampanini
Copy link
Member

@dlwyatt
Copy link
Member

dlwyatt commented Feb 10, 2023

I came here to report a similar issue. Just wanted to point out that in addition to the line that's being written from the godelw script, godel itself pollutes stdout some more when it's downloading plugins. The two calls to godelgetter.Download* could be updated to pass in stderr as the writer instead of stdout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants