Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godel verify with --parallel is slower than running checks serially #443

Open
k-simons opened this issue Feb 19, 2019 · 1 comment
Open

Comments

@k-simons
Copy link

k-simons commented Feb 19, 2019

On our team we have started migrating and encouraging setting up godel CI integration to use:
./godelw verify --skip-test --skip-check && ./godelw test && ./godelw check --parallel=false instead of just running ./godelw verify.

This is because the parallelism appears to be oversubscribed and running these tests serially is actually significantly faster (~40% from what we have seen) the just running ./godelw verify. Ideally we could fix ./godelw verify to be correctly more performant than running the tasks serially and stop bifurcating CI configuration.

@k-simons k-simons changed the title godel verify with --parallel is slower than running things serially godel verify with --parallel is slower than running checks serially Feb 19, 2019
@nmiyake
Copy link
Contributor

nmiyake commented Mar 25, 2019

@k-simons, I have some cycles to take a look at this now. When you get a chance, can you point me to some example projects where you observed this difference so that I can dig in?

I think this behavior may depend on the codebase/environment, as when I did some quick testing on the godel codebase on my laptop, running checks in parallel completed faster than running them serially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants