Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow hyphens from metric names/namespaces #34

Open
asanderson15 opened this issue Dec 5, 2019 · 1 comment
Open

Disallow hyphens from metric names/namespaces #34

asanderson15 opened this issue Dec 5, 2019 · 1 comment

Comments

@asanderson15
Copy link

asanderson15 commented Dec 5, 2019

No description provided.

@carterkozak
Copy link
Contributor

We could switch from banning underscore to banning hyphen, and update all consumers. Prometheus has a similar constraint and renames hyphens to underscores, but we found it was more common to define metrics in code using hyphens than underscores.

By producing metrics from a schema we can also produce documentation tailored specifically toward the normalized format we send to a collector so it may not be necessary to modify the inputs at all. I'd like to take it a step farther and build validation based on the schema so we don't need to worry about getting these things slightly wrong, the robots should be able to validate pre-merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants