Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy-bot requesting reviewers even when existing users are present #418

Open
asvoboda opened this issue May 10, 2022 · 0 comments
Open
Labels
bug Something isn't working

Comments

@asvoboda
Copy link
Member

I've noticed on some internal repos where the following occurs:

  • On a repo where request-review is enabled
  • In the create PR workflow, select a user manually who should review
  • Open the PR
  • Wait a sec, and policy-bot will still request another human for review

I believe this is kind of a bug. If the selected user satisfies the review request, we should probably skip requesting additional reviews on other users. If the manually selected user is not in the approval set, then we should continue automatically requesting reviewers.

@asvoboda asvoboda added the bug Something isn't working label May 10, 2022
@bluekeyes bluekeyes changed the title Policy-bot requesting reviewers event when existing users are present Policy-bot requesting reviewers even when existing users are present May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant