Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key_fingerprints to has_valid_signatures_by_keys predicate #505

Open
bluekeyes opened this issue Nov 30, 2022 · 0 comments
Open

Add key_fingerprints to has_valid_signatures_by_keys predicate #505

bluekeyes opened this issue Nov 30, 2022 · 0 comments
Labels
predicates A request or issue related to rule predicates

Comments

@bluekeyes
Copy link
Member

#504 added basic support for SSH commit signatures, but only for the has_valid_signatures and has_valid_signatures_by predicates. Because SSH keys use fingerprints instead of IDs, we should also add a key_fingerprints option to the has_valid_signatures_by_keys so that people can require signatures by specific SSH keys.

This would probably be an OR with the key_ids property, similar to how users, organizations, and teams combine in the has_valid_signatures_by predicate.

@bluekeyes bluekeyes added the predicates A request or issue related to rule predicates label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
predicates A request or issue related to rule predicates
Projects
None yet
Development

No branches or pull requests

1 participant