Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add fixer and new option to commentFormatRule #3583

Merged
merged 6 commits into from Jun 15, 2019
Merged

Add fixer and new option to commentFormatRule #3583

merged 6 commits into from Jun 15, 2019

Conversation

smoehrle
Copy link
Contributor

PR checklist

Overview of change:

  • change existing rule to only emit one error
  • add fixer
  • add option allow-trailing-lowercase

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[new-rule-option] "allow-trailing-lowercase" option for comment-format
[new-fixer] comment-format

src/rules/commentFormatRule.ts Outdated Show resolved Hide resolved
src/rules/commentFormatRule.ts Outdated Show resolved Hide resolved
src/rules/commentFormatRule.ts Outdated Show resolved Hide resolved
src/rules/commentFormatRule.ts Outdated Show resolved Hide resolved
@smoehrle
Copy link
Contributor Author

Is there anything that can be done to help you in the review process @ajafff?

@MichaelTontchev
Copy link

Has this been completed?

@JoshuaKGoldberg
Copy link
Contributor

I went ahead and fixed up the merge conflicts. Sorry this took so long @smoehrle - the changes look great and I'm excited to get to use them. Thanks so much for sending this PR back in the day! 😊

FYI @MichaelTontchev

@JoshuaKGoldberg JoshuaKGoldberg merged commit aa8c445 into palantir:master Jun 15, 2019
JoshuaKGoldberg pushed a commit that referenced this pull request Jun 15, 2019
I'd mistakenly added it in merging #3583. Whoops.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

comment-format check-uppercase false positive
4 participants