Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Security vulnerability at js-yaml #4596

Closed
pyrho opened this issue Mar 22, 2019 · 5 comments
Closed

Security vulnerability at js-yaml #4596

pyrho opened this issue Mar 22, 2019 · 5 comments

Comments

@pyrho
Copy link

pyrho commented Mar 22, 2019

A security issue had been found in js-yml which is a direct dependency of tslint.
js-yml 3.13.0 fixes the issue.

yarn audit output:

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ moderate      │ Denial of Service                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ js-yaml                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=3.13.0                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ tslint                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ tslint > js-yaml                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/788                       │
└───────────────┴──────────────────────────────────────────────────────────────┘
@adidahiya
Copy link
Contributor

Fixed by #4595

@vinaydasari
Copy link

@adidahiya Could you please release next version, so we can get benefit of this commit? Thank you

@adidahiya
Copy link
Contributor

@vinaydasari the commit from #4595 has been available since 5.15.0

@vinaydasari
Copy link

@adidahiya My bad. I was referring to 4663.
I found this issue with js-yaml and thought this is the one. But this is a different issue.
The PR above fixes it but it hasn't been released yet. It will be useful if you can release the new version as we are also close to the cadence as well I guess. And thanks alot for the quick response, really appreciate it.

@adidahiya
Copy link
Contributor

tslint's dependency range doesn't block you from upgrading js-yaml. it's a ^ version range so you should be able to get the latest js-yaml installed without any change from tslint itself

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants