Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

[enhancement] Update deprecated devDependency github to @octokit/rest #4673

Merged
merged 1 commit into from Apr 18, 2019

Conversation

bjornstar
Copy link
Contributor

PR checklist

Overview of change:

The github package has been deprecated -- https://git.io/vNB11

Is there anything you'd like reviewers to focus on?

The auth token is not necessary for public readonly access.

There were a few deprecated methods and properties that have been replaced by their modern equivalent.

I tested it locally and got the following output:

$ node ./scripts/generate-changelog.js
Getting commits 5.16.0..master

---- formatted changelog entries: ----
- [chore] Update mocha from v3.2.0 to v6.1.3 (#4669)
- [enhancement] Update dependency js-yaml from ^3.13.0 to ^3.13.1 (#4663)

---- PRs with missing changelog entries: ----
- Update docs config file
- VSCode plugin link updated (#4670)

---- thanks ----
Thanks to our contributors!
- Adi Dahiya
- Bjorn Stromberg
- Vitaliy Agoshkov

CHANGELOG.md entry:

[enhancement] Update deprecated devDependency github to @octokit/rest

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks @bjornstar

@adidahiya adidahiya merged commit d233a83 into palantir:master Apr 18, 2019
@adidahiya
Copy link
Contributor

Updated the wiki to reflect that we no longer need the auth token.

@adidahiya
Copy link
Contributor

Unfortunately I now get "HttpError: API rate limit exceeded" with this approach. So I think we will need to bring back authentication (which has a higher rate limit)

@adidahiya adidahiya mentioned this pull request May 30, 2019
@bjornstar bjornstar deleted the update-github branch April 12, 2021 04:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devDependency 'github' has been renamed to '@octokit/rest'
2 participants