Add noForIn rule #4747

jpike88 · 2019-05-29T05:49:39Z

PR checklist

Addresses an existing issue: fixes no-for-in #4504

Overview of change:

Is there anything you'd like reviewers to focus on?

I have no idea what I'm doing, this is taken straight from the Microsoft-tslint-contrib repo, with some minor tweaks made. Help lol

CHANGELOG.md entry:

[new-rule] no-for-in

palantirtech · 2019-05-29T05:49:40Z

Thanks for your interest in palantir/tslint, @jpike88! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

jpike88 · 2019-05-29T07:47:09Z

@JoshuaKGoldberg am trying to make that test pass... could you suggest the correct code for that?

JoshuaKGoldberg · 2019-05-29T21:03:58Z

@jpike88 please clean up build failures; we'll be able to review once they're done.

Note that there are a couple outside of this PR: #4745

Edit: sorry, just saw your comment! Mine wasn't very helpful. 😦 . +1 to adidahiya's suggestion.

adidahiya · 2019-05-30T19:48:30Z

Try merging master to get the fix for #4745

src/rules/noForInRule.ts

jpike88 · 2019-06-09T05:32:15Z

@JoshuaKGoldberg finally, looking forward to the pr and release!

jpike88 · 2019-06-13T09:45:55Z

Guys, any movement?

adidahiya · 2019-06-14T15:27:52Z

@jpike88 thanks for updating the PR, I'll take a look today

src/rules/noForInRule.ts

adidahiya · 2019-06-14T17:26:45Z

test/rules/no-for-in/test.ts.lint

+const object = {test:1, test2:1 ,test3:1};
+for (const key in object) {
+~~~~~~~~~~~~~~~~~~~~~~~~~~~
+	if (object.hasOwnProperty(key)) {.


stray trailing .

Suggested change

if (object.hasOwnProperty(key)) {.

if (object.hasOwnProperty(key)) {

Suggested change

if (object.hasOwnProperty(key)) {.

Suggested change

if (object.hasOwnProperty(key)) {.

if (object.hasOwnProperty(key)) {

test/rules/no-for-in/test.ts.lint

adidahiya · 2019-06-14T17:28:27Z

test/rules/no-for-in/test.ts.lint

@@ -0,0 +1,23 @@
+// this should pass


no need to write this, it's implied by the lack of lint failure marker

Suggested change

// this should pass

src/rules/noForInRule.ts

src/configuration.ts

Co-Authored-By: Adi Dahiya <adi.dahiya14@gmail.com>

test/rules/no-for-in/test.ts.lint

src/configuration.ts

src/rules/noForInRule.ts

src/configuration.ts

adidahiya · 2019-07-01T14:49:09Z

You missed some of my code suggestions - please go to the Files tab of the PR and apply them all as a batch

Co-Authored-By: Adi Dahiya <adi.dahiya14@gmail.com>

adidahiya

need to fix lint failure

src/rules/noForInRule.ts

Co-Authored-By: Adi Dahiya <adi.dahiya14@gmail.com>

jpike88 · 2019-07-04T01:35:35Z

@adidahiya at last... hopefully this is it lol

adidahiya · 2019-07-04T05:08:03Z

thanks @jpike88!

Add noForIn rule

0ee9fa2

Josh Pike added 3 commits May 29, 2019 14:20

tslint fixes

b3c8c97

test fixes

4fd5d47

test fix

3fc8769

JoshuaKGoldberg added the PR: waiting for author label May 29, 2019

JoshuaKGoldberg reviewed May 30, 2019

View reviewed changes

src/rules/noForInRule.ts Show resolved Hide resolved

Josh Pike added 10 commits June 7, 2019 16:58

Merge branch 'master' of https://github.com/palantir/tslint

771c056

Update noForInRule.ts

d23b986

fixed test errors

ae05ee6

Update exclusions.ts

d977b3c

Update configuration.ts

28038f9

fix tests

2edf878

FIX TESTS

9a2a5a2

Update test.ts.lint

7dfd006

Update test.ts.lint

2c4d184

fix tests

9a39d39

adidahiya removed the PR: waiting for author label Jun 13, 2019

adidahiya self-assigned this Jun 13, 2019

adidahiya suggested changes Jun 14, 2019

View reviewed changes

adidahiya added the PR: waiting for author label Jun 21, 2019

Update src/rules/noForInRule.ts

d1544fb

Co-Authored-By: Adi Dahiya <adi.dahiya14@gmail.com>

jpike88 commented Jun 28, 2019

View reviewed changes

test/rules/no-for-in/test.ts.lint Outdated Show resolved Hide resolved

Update test/rules/no-for-in/test.ts.lint

7fc2632

Update noForInRule.ts

1024247

adidahiya suggested changes Jul 1, 2019

View reviewed changes

Josh Pike and others added 2 commits July 3, 2019 13:22

Apply suggestions from code review

b79168b

Co-Authored-By: Adi Dahiya <adi.dahiya14@gmail.com>

Update configuration.ts

825f63f

adidahiya suggested changes Jul 3, 2019

View reviewed changes

src/rules/noForInRule.ts Outdated Show resolved Hide resolved

src/rules/noForInRule.ts Outdated Show resolved Hide resolved

Josh Pike and others added 2 commits July 4, 2019 09:32

Update src/rules/noForInRule.ts

6da67d8

Co-Authored-By: Adi Dahiya <adi.dahiya14@gmail.com>

Update src/rules/noForInRule.ts

b0d00ea

Co-Authored-By: Adi Dahiya <adi.dahiya14@gmail.com>

adidahiya approved these changes Jul 4, 2019

View reviewed changes

adidahiya merged commit f31dd94 into palantir:master Jul 4, 2019

adidahiya removed the PR: waiting for author label Jul 4, 2019

JoshuaKGoldberg mentioned this pull request Jul 4, 2019

Port tslint-microsoft-contrib's no-for-in #3550

Closed

adidahiya mentioned this pull request Aug 20, 2019

Prepare release v5.19.0 #4826

Merged

snyk-bot mentioned this pull request Oct 11, 2019

[Snyk] Upgrade tslint from 5.11.0 to 5.20.0 Narshe1412/nuarca-sql#21

Merged

snyk-bot mentioned this pull request Oct 26, 2019

[Snyk] Upgrade tslint from 5.12.1 to 5.20.0 ajesse11x/caprover#5

Open

snyk-bot mentioned this pull request Nov 15, 2019

[Snyk] Upgrade tslint from 5.8.0 to 5.20.1 Matthelonianxl/cli-build-app#7

Open

snyk-bot mentioned this pull request Dec 15, 2019

[Snyk] Upgrade tslint from 5.11.0 to 5.20.1 dyna-dot/arxiv-bib-overlay#1

Open

snyk-bot mentioned this pull request Feb 19, 2020

[Snyk] Upgrade tslint from 5.9.1 to 5.20.1 hmcts/vh-admin-web#230

Merged

snyk-bot mentioned this pull request Mar 31, 2020

[Snyk] Upgrade tslint from 5.8.0 to 5.20.1 baophucct/trust-ray#6

Open

snyk-bot mentioned this pull request Apr 12, 2020

[Snyk] Upgrade tslint from 5.18.0 to 5.20.1 speech4j/web#14

Closed

snyk-bot mentioned this pull request Apr 22, 2020

[Snyk] Upgrade tslint from 5.9.1 to 5.20.1 Narshe1412/APMTraining#19

Open

dependabot bot mentioned this pull request Mar 15, 2021

Bump tslint from 5.9.1 to 5.20.1 CartoonIsArt/CIAPI#130

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add noForIn rule #4747

Add noForIn rule #4747

jpike88 commented May 29, 2019 •

edited by adidahiya

palantirtech commented May 29, 2019

jpike88 commented May 29, 2019

JoshuaKGoldberg commented May 29, 2019 •

edited

adidahiya commented May 30, 2019

jpike88 commented Jun 9, 2019

jpike88 commented Jun 13, 2019

adidahiya commented Jun 14, 2019

adidahiya Jun 14, 2019

jpike88 Jun 28, 2019

jpike88 Jun 28, 2019

jpike88 Jun 28, 2019

adidahiya Jun 14, 2019

jpike88 Jun 28, 2019

adidahiya commented Jul 1, 2019

adidahiya left a comment

jpike88 commented Jul 4, 2019

adidahiya commented Jul 4, 2019

	if (object.hasOwnProperty(key)) {.
	if (object.hasOwnProperty(key)) {

Add noForIn rule #4747

Add noForIn rule #4747

Conversation

jpike88 commented May 29, 2019 • edited by adidahiya

PR checklist

Overview of change:

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

palantirtech commented May 29, 2019

jpike88 commented May 29, 2019

JoshuaKGoldberg commented May 29, 2019 • edited

adidahiya commented May 30, 2019

jpike88 commented Jun 9, 2019

jpike88 commented Jun 13, 2019

adidahiya commented Jun 14, 2019

adidahiya Jun 14, 2019

Choose a reason for hiding this comment

jpike88 Jun 28, 2019

Choose a reason for hiding this comment

jpike88 Jun 28, 2019

Choose a reason for hiding this comment

jpike88 Jun 28, 2019

Choose a reason for hiding this comment

adidahiya Jun 14, 2019

Choose a reason for hiding this comment

jpike88 Jun 28, 2019

Choose a reason for hiding this comment

adidahiya commented Jul 1, 2019

adidahiya left a comment

Choose a reason for hiding this comment

jpike88 commented Jul 4, 2019

adidahiya commented Jul 4, 2019

jpike88 commented May 29, 2019 •

edited by adidahiya

JoshuaKGoldberg commented May 29, 2019 •

edited