Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

fix: add bigint support to restrict-plus-operand rule #4814

Merged

Conversation

vedadeepta
Copy link
Contributor

@vedadeepta vedadeepta commented Jul 27, 2019

PR checklist

Overview of change:

Add support for bigint in restrict-plus-operand rule. Checks if the node type is equal ts.TypeFlags.BigInt or ts.TypeFlags.BigIntLiteral.

Is there anything you'd like reviewers to focus on?

Maybe make this optional because bigint is not supported below typescript 3.2 and is not supported for javascript target es2017 & below. More on this typscript caveats.

CHANGELOG.md entry:

[enhancement] add BigInt support to restrict-plus-operands rule

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this doesn't need to be optional behavior, lgtm, thanks

@adidahiya adidahiya merged commit e17ea57 into palantir:master Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"restrict-plus-operands" doesn't understand BigInt
2 participants