Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Added allow-generics option to invalid-void rule #4839

Merged
merged 6 commits into from Sep 9, 2019
Merged

Added allow-generics option to invalid-void rule #4839

merged 6 commits into from Sep 9, 2019

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 25, 2019 •
edited

PR checklist

Overview of change:

Adds an allow-generics option to invalid-void for the sake of common uses such as Promise<void>. It's true by default, can be specified as false, and also allows a string[] whitelist: e.g. "allow-generics": ["Promise"].

CHANGELOG.md entry:

[new-rule-option]: Added allow-generics to invalid-void

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 31, 2019 13:40
adidahiya
adidahiya suggested changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, let's just improve the error messages a bit

src/rules/invalidVoidRule.ts Outdated Show resolved Hide resolved
src/rules/invalidVoidRule.ts Outdated Show resolved Hide resolved
src/rules/invalidVoidRule.ts Outdated Show resolved Hide resolved
@adidahiya
Apply suggestions from code review
3c4f368 
Thanks!

Co-Authored-By: Adi Dahiya <adi.dahiya14@gmail.com>
@JoshuaKGoldberg
Copy link
Contributor Author

Thanks @adidahiya - sorry about the delay!

@adidahiya adidahiya merged commit a15541d into palantir:master Sep 9, 2019
@JoshuaKGoldberg JoshuaKGoldberg deleted the invalid-void-generics branch September 9, 2019 02:30
@adidahiya adidahiya mentioned this pull request Sep 10, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 11, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
This was referenced Nov 13, 2019
Merged
Merged
Open
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 19, 2020
Merged
This was referenced Mar 18, 2020
Closed
Open
Open
Open
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees

@adidahiya adidahiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async function return void cause invalid void
2 participants
@JoshuaKGoldberg @adidahiya